diff options
| author | Johannes Berg <johannes.berg@intel.com> | 2010-10-07 12:55:24 +0200 |
|---|---|---|
| committer | John W. Linville <linville@tuxdriver.com> | 2010-10-07 14:41:27 -0400 |
| commit | 7b99a7c2dab7efe7c265b66fedbf3444958ebfe3 (patch) | |
| tree | d45093d306d686d4cb0cdc391c6895f372b20495 /net/mac80211/scan.c | |
| parent | 4b34d432b0fcff422304de4eb49d6da861fe335c (diff) | |
| download | linux-7b99a7c2dab7efe7c265b66fedbf3444958ebfe3.tar.gz linux-7b99a7c2dab7efe7c265b66fedbf3444958ebfe3.tar.bz2 linux-7b99a7c2dab7efe7c265b66fedbf3444958ebfe3.zip | |
mac80211: fix sw scan locking
The recent scan overhaul broke locking
because now we can jump to code that
attempts to unlock, while we don't have
the mutex held. Fix this by holding the
mutex around all the relevant code.
Reported-by: Ben Greear <greearb@candelatech.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'net/mac80211/scan.c')
| -rw-r--r-- | net/mac80211/scan.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/mac80211/scan.c b/net/mac80211/scan.c index 523db930dabb..fb274db77e3c 100644 --- a/net/mac80211/scan.c +++ b/net/mac80211/scan.c @@ -681,8 +681,6 @@ void ieee80211_scan_work(struct work_struct *work) goto out_complete; } - mutex_unlock(&local->mtx); - /* * as long as no delay is required advance immediately * without scheduling a new work @@ -713,6 +711,7 @@ void ieee80211_scan_work(struct work_struct *work) } while (next_delay == 0); ieee80211_queue_delayed_work(&local->hw, &local->scan_work, next_delay); + mutex_unlock(&local->mtx); return; out_complete: |