diff options
| author | Kuniyuki Iwashima <kuniyu@amazon.com> | 2022-07-20 09:50:18 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-07-22 12:06:17 +0100 |
| commit | 780476488844e070580bfc9e3bc7832ec1cea883 (patch) | |
| tree | 1c5eccb931a4222e45ac290ef3c7334db3a0df50 /net/mptcp | |
| parent | ab1ba21b523ab496b1a4a8e396333b24b0a18f9a (diff) | |
| download | linux-780476488844e070580bfc9e3bc7832ec1cea883.tar.gz linux-780476488844e070580bfc9e3bc7832ec1cea883.tar.bz2 linux-780476488844e070580bfc9e3bc7832ec1cea883.zip | |
tcp: Fix data-races around sysctl_tcp_moderate_rcvbuf.
While reading sysctl_tcp_moderate_rcvbuf, it can be changed
concurrently. Thus, we need to add READ_ONCE() to its readers.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/mptcp')
| -rw-r--r-- | net/mptcp/protocol.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c index 21a3ed64226e..9bbd8cbe0acb 100644 --- a/net/mptcp/protocol.c +++ b/net/mptcp/protocol.c @@ -1908,7 +1908,7 @@ static void mptcp_rcv_space_adjust(struct mptcp_sock *msk, int copied) if (msk->rcvq_space.copied <= msk->rcvq_space.space) goto new_measure; - if (sock_net(sk)->ipv4.sysctl_tcp_moderate_rcvbuf && + if (READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_moderate_rcvbuf) && !(sk->sk_userlocks & SOCK_RCVBUF_LOCK)) { int rcvmem, rcvbuf; u64 rcvwin, grow; |