diff options
| author | Xiyu Yang <xiyuyang19@fudan.edu.cn> | 2020-04-15 16:36:19 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-04-18 13:09:46 -0700 |
| commit | d03f228470a8c0a22b774d1f8d47071e0de4f6dd (patch) | |
| tree | 2b62e9da1a2a8e3346cfd2712abab732dfa4089c /net/netrom | |
| parent | 2fcd80144b93ff90836a44f2054b4d82133d3a85 (diff) | |
| download | linux-d03f228470a8c0a22b774d1f8d47071e0de4f6dd.tar.gz linux-d03f228470a8c0a22b774d1f8d47071e0de4f6dd.tar.bz2 linux-d03f228470a8c0a22b774d1f8d47071e0de4f6dd.zip | |
net: netrom: Fix potential nr_neigh refcnt leak in nr_add_node
nr_add_node() invokes nr_neigh_get_dev(), which returns a local
reference of the nr_neigh object to "nr_neigh" with increased refcnt.
When nr_add_node() returns, "nr_neigh" becomes invalid, so the refcount
should be decreased to keep refcount balanced.
The issue happens in one normal path of nr_add_node(), which forgets to
decrease the refcnt increased by nr_neigh_get_dev() and causes a refcnt
leak. It should decrease the refcnt before the function returns like
other normal paths do.
Fix this issue by calling nr_neigh_put() before the nr_add_node()
returns.
Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/netrom')
| -rw-r--r-- | net/netrom/nr_route.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c index 79f12d8c7b86..0891ee02ca4f 100644 --- a/net/netrom/nr_route.c +++ b/net/netrom/nr_route.c @@ -208,6 +208,7 @@ static int __must_check nr_add_node(ax25_address *nr, const char *mnemonic, /* refcount initialized at 1 */ spin_unlock_bh(&nr_node_list_lock); + nr_neigh_put(nr_neigh); return 0; } nr_node_lock(nr_node); |