diff options
author | Jordan Rife <jrife@google.com> | 2023-09-21 18:46:42 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2023-10-01 19:31:29 +0100 |
commit | c889a99a21bf124c3db08d09df919f0eccc5ea4c (patch) | |
tree | 18c63a51bfbee4af1f62a89a688ba25c7c05697e /net/rds/tcp_listen.c | |
parent | 86a7e0b69bd5b812e48a20c66c2161744f3caa16 (diff) | |
download | linux-c889a99a21bf124c3db08d09df919f0eccc5ea4c.tar.gz linux-c889a99a21bf124c3db08d09df919f0eccc5ea4c.tar.bz2 linux-c889a99a21bf124c3db08d09df919f0eccc5ea4c.zip |
net: prevent address rewrite in kernel_bind()
Similar to the change in commit 0bdf399342c5("net: Avoid address
overwrite in kernel_connect"), BPF hooks run on bind may rewrite the
address passed to kernel_bind(). This change
1) Makes a copy of the bind address in kernel_bind() to insulate
callers.
2) Replaces direct calls to sock->ops->bind() in net with kernel_bind()
Link: https://lore.kernel.org/netdev/20230912013332.2048422-1-jrife@google.com/
Fixes: 4fbac77d2d09 ("bpf: Hooks for sys_bind")
Cc: stable@vger.kernel.org
Reviewed-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: Jordan Rife <jrife@google.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/rds/tcp_listen.c')
-rw-r--r-- | net/rds/tcp_listen.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/rds/tcp_listen.c b/net/rds/tcp_listen.c index 014fa24418c1..53b3535a1e4a 100644 --- a/net/rds/tcp_listen.c +++ b/net/rds/tcp_listen.c @@ -306,7 +306,7 @@ struct socket *rds_tcp_listen_init(struct net *net, bool isv6) addr_len = sizeof(*sin); } - ret = sock->ops->bind(sock, (struct sockaddr *)&ss, addr_len); + ret = kernel_bind(sock, (struct sockaddr *)&ss, addr_len); if (ret < 0) { rdsdebug("could not bind %s listener socket: %d\n", isv6 ? "IPv6" : "IPv4", ret); |