diff options
| author | Dan Carpenter <error27@gmail.com> | 2022-11-17 10:43:38 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-11-18 12:02:05 +0000 |
| commit | 101c1bb6c55691d01c73915c118828f7ca17a049 (patch) | |
| tree | 292d079befc707c18b92fb21b683dfc8ea27ee92 /net/rxrpc/rxkad.c | |
| parent | ec8cd134eeeecef9cccb5431b1a3f140ff2a413a (diff) | |
| download | linux-101c1bb6c55691d01c73915c118828f7ca17a049.tar.gz linux-101c1bb6c55691d01c73915c118828f7ca17a049.tar.bz2 linux-101c1bb6c55691d01c73915c118828f7ca17a049.zip | |
rxrpc: fix rxkad_verify_response()
The error handling for if skb_copy_bits() fails was accidentally deleted
so the rxkad_decrypt_ticket() function is not called.
Fixes: 5d7edbc9231e ("rxrpc: Get rid of the Rx ring")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: David Howells <dhowells@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/rxrpc/rxkad.c')
| -rw-r--r-- | net/rxrpc/rxkad.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/net/rxrpc/rxkad.c b/net/rxrpc/rxkad.c index 2706e59bf992..110a5550c0a6 100644 --- a/net/rxrpc/rxkad.c +++ b/net/rxrpc/rxkad.c @@ -1165,8 +1165,10 @@ static int rxkad_verify_response(struct rxrpc_connection *conn, eproto = tracepoint_string("rxkad_tkt_short"); abort_code = RXKADPACKETSHORT; - if (skb_copy_bits(skb, sizeof(struct rxrpc_wire_header) + sizeof(*response), - ticket, ticket_len) < 0) + ret = skb_copy_bits(skb, sizeof(struct rxrpc_wire_header) + sizeof(*response), + ticket, ticket_len); + if (ret < 0) + goto temporary_error_free_ticket; ret = rxkad_decrypt_ticket(conn, server_key, skb, ticket, ticket_len, &session_key, &expiry, _abort_code); |