diff options
| author | Anna Schumaker <Anna.Schumaker@Netapp.com> | 2023-06-23 11:43:14 -0400 |
|---|---|---|
| committer | Anna Schumaker <Anna.Schumaker@Netapp.com> | 2023-08-23 15:58:47 -0400 |
| commit | 61182c796d74f54ba66d17bac6f516183ec09af2 (patch) | |
| tree | d33fc5c105f0b1198f63c6bf0fa7041c18bca164 /net/sunrpc/svc.c | |
| parent | 303a78052091c81e9003915c521fdca1c7e117af (diff) | |
| download | linux-61182c796d74f54ba66d17bac6f516183ec09af2.tar.gz linux-61182c796d74f54ba66d17bac6f516183ec09af2.tar.bz2 linux-61182c796d74f54ba66d17bac6f516183ec09af2.zip | |
SUNRPC: kmap() the xdr pages during decode
If the pages are in HIGHMEM then we need to make sure they're mapped
before trying to read data off of them, otherwise we could end up with a
NULL pointer dereference.
The downside to this is that we need an extra cleanup step at the end of
decode to kunmap() the last page. I introduced an xdr_finish_decode()
function to do this. Right now this function only calls the
unmap_current_page() function, but other generic cleanup steps could be
added in the future if we come across anything else.
Reported-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Diffstat (limited to 'net/sunrpc/svc.c')
| -rw-r--r-- | net/sunrpc/svc.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c index 587811a002c9..a864414ce811 100644 --- a/net/sunrpc/svc.c +++ b/net/sunrpc/svc.c @@ -1370,6 +1370,8 @@ svc_process_common(struct svc_rqst *rqstp) rc = process.dispatch(rqstp); if (procp->pc_release) procp->pc_release(rqstp); + xdr_finish_decode(xdr); + if (!rc) goto dropit; if (rqstp->rq_auth_stat != rpc_auth_ok) |