diff options
| author | Xin Xiong <xiongx18@fudan.edu.cn> | 2022-08-10 23:29:13 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-08-12 11:21:28 +0100 |
| commit | bfc48f1b0505ffcb03a6d749139b7577d6b81ae0 (patch) | |
| tree | 02acba0b72a6045625b6111c25b47642039af5e1 /net/sunrpc/sysfs.c | |
| parent | 86d2155e48f6ce1aacbd01667176e5b915ae275c (diff) | |
| download | linux-bfc48f1b0505ffcb03a6d749139b7577d6b81ae0.tar.gz linux-bfc48f1b0505ffcb03a6d749139b7577d6b81ae0.tar.bz2 linux-bfc48f1b0505ffcb03a6d749139b7577d6b81ae0.zip | |
net/sunrpc: fix potential memory leaks in rpc_sysfs_xprt_state_change()
The issue happens on some error handling paths. When the function
fails to grab the object `xprt`, it simply returns 0, forgetting to
decrease the reference count of another object `xps`, which is
increased by rpc_sysfs_xprt_kobj_get_xprt_switch(), causing refcount
leaks. Also, the function forgets to check whether `xps` is valid
before using it, which may result in NULL-dereferencing issues.
Fix it by adding proper error handling code when either `xprt` or
`xps` is NULL.
Fixes: 5b7eb78486cd ("SUNRPC: take a xprt offline using sysfs")
Signed-off-by: Xin Xiong <xiongx18@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sunrpc/sysfs.c')
| -rw-r--r-- | net/sunrpc/sysfs.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/net/sunrpc/sysfs.c b/net/sunrpc/sysfs.c index 7330eb9a70cf..c65c90ad626a 100644 --- a/net/sunrpc/sysfs.c +++ b/net/sunrpc/sysfs.c @@ -291,8 +291,10 @@ static ssize_t rpc_sysfs_xprt_state_change(struct kobject *kobj, int offline = 0, online = 0, remove = 0; struct rpc_xprt_switch *xps = rpc_sysfs_xprt_kobj_get_xprt_switch(kobj); - if (!xprt) - return 0; + if (!xprt || !xps) { + count = 0; + goto out_put; + } if (!strncmp(buf, "offline", 7)) offline = 1; |