summaryrefslogtreecommitdiffstats
path: root/net/wireless
diff options
context:
space:
mode:
authorJulian Squires <julian@cipht.net>2020-07-06 17:13:53 -0400
committerJohannes Berg <johannes.berg@intel.com>2020-07-30 10:24:01 +0200
commit4052d3d2e8f47a15053320bbcbe365d15610437d (patch)
tree7e71b33bfcd5c53830921859b0748e0da77ed67a /net/wireless
parent5e43540c2af0a0c0a18e39579b1ad49541f87506 (diff)
downloadlinux-4052d3d2e8f47a15053320bbcbe365d15610437d.tar.gz
linux-4052d3d2e8f47a15053320bbcbe365d15610437d.tar.bz2
linux-4052d3d2e8f47a15053320bbcbe365d15610437d.zip
cfg80211: check vendor command doit pointer before use
In the case where a vendor command does not implement doit, and has no flags set, doit would not be validated and a NULL pointer dereference would occur, for example when invoking the vendor command via iw. I encountered this while developing new vendor commands. Perhaps in practice it is advisable to always implement doit along with dumpit, but it seems reasonable to me to always check doit anyway, not just when NEED_WDEV. Signed-off-by: Julian Squires <julian@cipht.net> Link: https://lore.kernel.org/r/20200706211353.2366470-1-julian@cipht.net Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net/wireless')
-rw-r--r--net/wireless/nl80211.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 0e07fb8585fb..7fbca0854265 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -13266,13 +13266,13 @@ static int nl80211_vendor_cmd(struct sk_buff *skb, struct genl_info *info)
if (!wdev_running(wdev))
return -ENETDOWN;
}
-
- if (!vcmd->doit)
- return -EOPNOTSUPP;
} else {
wdev = NULL;
}
+ if (!vcmd->doit)
+ return -EOPNOTSUPP;
+
if (info->attrs[NL80211_ATTR_VENDOR_DATA]) {
data = nla_data(info->attrs[NL80211_ATTR_VENDOR_DATA]);
len = nla_len(info->attrs[NL80211_ATTR_VENDOR_DATA]);