summaryrefslogtreecommitdiffstats
path: root/net/wireless
diff options
context:
space:
mode:
authorJohannes Berg <johannes.berg@intel.com>2020-02-21 10:41:43 +0100
committerJohannes Berg <johannes.berg@intel.com>2020-02-21 10:50:26 +0100
commit9951ebfcdf2b97dbb28a5d930458424341e61aa2 (patch)
tree1620972f990a1645f2ddfdb054ce8fe8f5773fb9 /net/wireless
parent36a44bcdd8df092d76c11bc213e81c5817d4e302 (diff)
downloadlinux-9951ebfcdf2b97dbb28a5d930458424341e61aa2.tar.gz
linux-9951ebfcdf2b97dbb28a5d930458424341e61aa2.tar.bz2
linux-9951ebfcdf2b97dbb28a5d930458424341e61aa2.zip
nl80211: fix potential leak in AP start
If nl80211_parse_he_obss_pd() fails, we leak the previously allocated ACL memory. Free it in this case. Fixes: 796e90f42b7e ("cfg80211: add support for parsing OBBS_PD attributes") Signed-off-by: Johannes Berg <johannes.berg@intel.com> Link: https://lore.kernel.org/r/20200221104142.835aba4cdd14.I1923b55ba9989c57e13978f91f40bfdc45e60cbd@changeid Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net/wireless')
-rw-r--r--net/wireless/nl80211.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index cedf17d4933f..46be40e19e7f 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -4800,8 +4800,7 @@ static int nl80211_start_ap(struct sk_buff *skb, struct genl_info *info)
err = nl80211_parse_he_obss_pd(
info->attrs[NL80211_ATTR_HE_OBSS_PD],
&params.he_obss_pd);
- if (err)
- return err;
+ goto out;
}
nl80211_calculate_ap_params(&params);
@@ -4823,6 +4822,7 @@ static int nl80211_start_ap(struct sk_buff *skb, struct genl_info *info)
}
wdev_unlock(wdev);
+out:
kfree(params.acl);
return err;