diff options
| author | Amol Grover <frextrite@gmail.com> | 2020-05-14 23:31:02 +0530 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-05-14 18:01:07 -0700 |
| commit | a14fbcd4f157a5a97b6013289205559d246c5021 (patch) | |
| tree | b26b94c280baf475706fc18fb56594f5c821787a /net | |
| parent | 95f59bf88bb75281cc626e283ecefdd5d5641427 (diff) | |
| download | linux-a14fbcd4f157a5a97b6013289205559d246c5021.tar.gz linux-a14fbcd4f157a5a97b6013289205559d246c5021.tar.bz2 linux-a14fbcd4f157a5a97b6013289205559d246c5021.zip | |
ipmr: Fix RCU list debugging warning
ipmr_for_each_table() macro uses list_for_each_entry_rcu()
for traversing outside of an RCU read side critical section
but under the protection of rtnl_mutex. Hence, add the
corresponding lockdep expression to silence the following
false-positive warning at boot:
[ 4.319347] =============================
[ 4.319349] WARNING: suspicious RCU usage
[ 4.319351] 5.5.4-stable #17 Tainted: G E
[ 4.319352] -----------------------------
[ 4.319354] net/ipv4/ipmr.c:1757 RCU-list traversed in non-reader section!!
Fixes: f0ad0860d01e ("ipv4: ipmr: support multiple tables")
Signed-off-by: Amol Grover <frextrite@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ipv4/ipmr.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c index 9cf83cc85e4a..4897f7420c8f 100644 --- a/net/ipv4/ipmr.c +++ b/net/ipv4/ipmr.c @@ -110,7 +110,8 @@ static void ipmr_expire_process(struct timer_list *t); #ifdef CONFIG_IP_MROUTE_MULTIPLE_TABLES #define ipmr_for_each_table(mrt, net) \ - list_for_each_entry_rcu(mrt, &net->ipv4.mr_tables, list) + list_for_each_entry_rcu(mrt, &net->ipv4.mr_tables, list, \ + lockdep_rtnl_is_held()) static struct mr_table *ipmr_mr_table_iter(struct net *net, struct mr_table *mrt) |