summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorElena Reshetova <elena.reshetova@intel.com>2017-11-29 13:15:46 +0200
committerJ. Bruce Fields <bfields@redhat.com>2017-12-21 15:24:19 -0500
commitd9226ec9ef01832b1edc1781241920614c6407db (patch)
treed28a4ba9af2ad21241a8746c03c0da82ef5f1ea2 /net
parent8bb3ea77933e9796f8f15a5492481a96af8302d6 (diff)
downloadlinux-d9226ec9ef01832b1edc1781241920614c6407db.tar.gz
linux-d9226ec9ef01832b1edc1781241920614c6407db.tar.bz2
linux-d9226ec9ef01832b1edc1781241920614c6407db.zip
lockd: convert nlm_rqst.a_count from atomic_t to refcount_t
atomic_t variables are currently used to implement reference counters with the following properties: - counter is initialized to 1 using atomic_set() - a resource is freed upon counter reaching zero - once counter reaches zero, its further increments aren't allowed - counter schema uses basic atomic operations (set, inc, inc_not_zero, dec_and_test, etc.) Such atomic variables should be converted to a newly provided refcount_t type and API that prevents accidental counter overflows and underflows. This is important since overflows and underflows can lead to use-after-free situation and be exploitable. The variable nlm_rqst.a_count is used as pure reference counter. Convert it to refcount_t and fix up the operations. **Important note for maintainers: Some functions from refcount_t API defined in lib/refcount.c have different memory ordering guarantees than their atomic counterparts. The full comparison can be seen in https://lkml.org/lkml/2017/11/15/57 and it is hopefully soon in state to be merged to the documentation tree. Normally the differences should not matter since refcount_t provides enough guarantees to satisfy the refcounting use cases, but in some rare cases it might matter. Please double check that you don't have some undocumented memory guarantees for this variable usage. For the nlm_rqst.a_count it might make a difference in following places: - nlmclnt_release_call() and nlmsvc_release_call(): decrement in refcount_dec_and_test() only provides RELEASE ordering and control dependency on success vs. fully ordered atomic counterpart Suggested-by: Kees Cook <keescook@chromium.org> Reviewed-by: David Windsor <dwindsor@gmail.com> Reviewed-by: Hans Liljestrand <ishkamiel@gmail.com> Signed-off-by: Elena Reshetova <elena.reshetova@intel.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions