diff options
| author | Danilo Krummrich <dakr@kernel.org> | 2025-03-19 15:52:55 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-03-20 07:41:07 -0700 |
| commit | 935e1d90bf6f14cd190b3a95f3cbf7e298123043 (patch) | |
| tree | 8187166b8f56077244bb1a473011b63139ec48e0 /rust/kernel/pci.rs | |
| parent | 455943aa187fd93358ccd00c894934061153ec0c (diff) | |
| download | linux-935e1d90bf6f14cd190b3a95f3cbf7e298123043.tar.gz linux-935e1d90bf6f14cd190b3a95f3cbf7e298123043.tar.bz2 linux-935e1d90bf6f14cd190b3a95f3cbf7e298123043.zip | |
rust: pci: require Send for Driver trait implementers
The instance of Self, returned and created by Driver::probe() is
dropped in the bus' remove() callback.
Request implementers of the Driver trait to implement Send, since the
remove() callback is not guaranteed to run from the same thread as
probe().
Fixes: 1bd8b6b2c5d3 ("rust: pci: add basic PCI device / driver abstractions")
Cc: stable <stable@kernel.org>
Reported-by: Alice Ryhl <aliceryhl@google.com>
Closes: https://lore.kernel.org/lkml/Z9rDxOJ2V2bPjj5i@google.com/
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
Reviewed-by: Benno Lossin <benno.lossin@proton.me>
Link: https://lore.kernel.org/r/20250319145350.69543-1-dakr@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'rust/kernel/pci.rs')
| -rw-r--r-- | rust/kernel/pci.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/rust/kernel/pci.rs b/rust/kernel/pci.rs index 0d09ae34a64d..22a32172b108 100644 --- a/rust/kernel/pci.rs +++ b/rust/kernel/pci.rs @@ -222,7 +222,7 @@ macro_rules! pci_device_table { ///``` /// Drivers must implement this trait in order to get a PCI driver registered. Please refer to the /// `Adapter` documentation for an example. -pub trait Driver { +pub trait Driver: Send { /// The type holding information about each device id supported by the driver. /// /// TODO: Use associated_type_defaults once stabilized: |