diff options
| author | Masahiro Yamada <masahiroy@kernel.org> | 2025-01-03 16:30:41 +0900 |
|---|---|---|
| committer | Masahiro Yamada <masahiroy@kernel.org> | 2025-01-10 23:01:22 +0900 |
| commit | 2480f53f21b21eb24a33815d4623f54fdb30cf27 (patch) | |
| tree | 7fbbc164786ec2577b9098ed7eab31cfd0d7adb1 /scripts/genksyms | |
| parent | f034d186bf9e2857079815e5490e2810a1a287a6 (diff) | |
| download | linux-2480f53f21b21eb24a33815d4623f54fdb30cf27.tar.gz linux-2480f53f21b21eb24a33815d4623f54fdb30cf27.tar.bz2 linux-2480f53f21b21eb24a33815d4623f54fdb30cf27.zip | |
genksyms: refactor the return points in the for-loop in __add_symbol()
free_list() must be called before returning from this for-loop.
Swap 'break' and the combination of free_list() and 'return'.
This reduces the code and minimizes the risk of introducing memory
leaks in future changes.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'scripts/genksyms')
| -rw-r--r-- | scripts/genksyms/genksyms.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/scripts/genksyms/genksyms.c b/scripts/genksyms/genksyms.c index 5a90acd693f4..41d6cfce0088 100644 --- a/scripts/genksyms/genksyms.c +++ b/scripts/genksyms/genksyms.c @@ -231,7 +231,7 @@ static struct symbol *__add_symbol(const char *name, enum symbol_type type, continue; if (is_reference) { - /* fall through */ ; + break; } else if (sym->type == type && equal_list(sym->defn, defn)) { if (!sym->is_declared && sym->is_override) { print_location(); @@ -239,25 +239,21 @@ static struct symbol *__add_symbol(const char *name, enum symbol_type type, fprintf(stderr, " modversion is unchanged\n"); } sym->is_declared = 1; - free_list(defn, NULL); - return sym; } else if (sym->is_declared) { error_with_pos("redefinition of %s", name); - free_list(defn, NULL); - return sym; } else if (sym->is_override && flag_preserve) { print_location(); fprintf(stderr, "ignoring "); print_type_name(type, name); fprintf(stderr, " modversion change\n"); sym->is_declared = 1; - free_list(defn, NULL); - return sym; } else { status = is_unknown_symbol(sym) ? STATUS_DEFINED : STATUS_MODIFIED; + break; } - break; + free_list(defn, NULL); + return sym; } if (sym) { |