diff options
| author | Kees Cook <keescook@chromium.org> | 2020-06-03 13:28:45 -0700 |
|---|---|---|
| committer | Kees Cook <keescook@chromium.org> | 2020-07-16 12:32:25 -0700 |
| commit | aecfd220b223043475fa515aa563249f683fcd04 (patch) | |
| tree | 0b1add5f2d86a4707d42501aab3efcb661c371c2 /scripts/get_dvb_firmware | |
| parent | 4b19bec97c882da09f7fd600895e0df1534a58dc (diff) | |
| download | linux-aecfd220b223043475fa515aa563249f683fcd04.tar.gz linux-aecfd220b223043475fa515aa563249f683fcd04.tar.bz2 linux-aecfd220b223043475fa515aa563249f683fcd04.zip | |
x86/mm/numa: Remove uninitialized_var() usage
Using uninitialized_var() is dangerous as it papers over real bugs[1]
(or can in the future), and suppresses unrelated compiler warnings (e.g.
"unused variable"). If the compiler thinks it is uninitialized, either
simply initialize the variable or make compiler changes. As a precursor
to removing[2] this[3] macro[4], refactor code to avoid its need.
The original reason for its use here was to work around the #ifdef
being the only place the variable was used. This is better expressed
using IS_ENABLED() and a new code block where the variable can be used
unconditionally.
[1] https://lore.kernel.org/lkml/20200603174714.192027-1-glider@google.com/
[2] https://lore.kernel.org/lkml/CA+55aFw+Vbj0i=1TGqCR5vQkCzWJ0QxK6CernOU6eedsudAixw@mail.gmail.com/
[3] https://lore.kernel.org/lkml/CA+55aFwgbgqhbp1fkxvRKEpzyR5J8n1vKT1VZdz9knmPuXhOeg@mail.gmail.com/
[4] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/
Fixes: 1e01979c8f50 ("x86, numa: Implement pfn -> nid mapping granularity check")
Signed-off-by: Kees Cook <keescook@chromium.org>
Diffstat (limited to 'scripts/get_dvb_firmware')
0 files changed, 0 insertions, 0 deletions