diff options
author | Masahiro Yamada <masahiroy@kernel.org> | 2021-04-30 10:56:27 +0900 |
---|---|---|
committer | Masahiro Yamada <masahiroy@kernel.org> | 2021-05-02 00:43:35 +0900 |
commit | 77a88274dc1a2cf3a775161d9a3242bc798ee680 (patch) | |
tree | 2352fd3b320c6801235ffb8c2cd80632c4fbfa69 /scripts/setlocalversion | |
parent | 885480b084696331bea61a4f7eba10652999a9c1 (diff) | |
download | linux-77a88274dc1a2cf3a775161d9a3242bc798ee680.tar.gz linux-77a88274dc1a2cf3a775161d9a3242bc798ee680.tar.bz2 linux-77a88274dc1a2cf3a775161d9a3242bc798ee680.zip |
kbuild: replace LANG=C with LC_ALL=C
LANG gives a weak default to each LC_* in case it is not explicitly
defined. LC_ALL, if set, overrides all other LC_* variables.
LANG < LC_CTYPE, LC_COLLATE, LC_MONETARY, LC_NUMERIC, ... < LC_ALL
This is why documentation such as [1] suggests to set LC_ALL in build
scripts to get the deterministic result.
LANG=C is not strong enough to override LC_* that may be set by end
users.
[1]: https://reproducible-builds.org/docs/locales/
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
Reviewed-by: Matthias Maennich <maennich@google.com>
Acked-by: Matthieu Baerts <matthieu.baerts@tessares.net> (mptcp)
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'scripts/setlocalversion')
-rwxr-xr-x | scripts/setlocalversion | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/setlocalversion b/scripts/setlocalversion index bb709eda96cd..db941f6d9591 100755 --- a/scripts/setlocalversion +++ b/scripts/setlocalversion @@ -126,7 +126,7 @@ scm_version() fi # Check for svn and a svn repo. - if rev=$(LANG= LC_ALL= LC_MESSAGES=C svn info 2>/dev/null | grep '^Last Changed Rev'); then + if rev=$(LC_ALL=C svn info 2>/dev/null | grep '^Last Changed Rev'); then rev=$(echo $rev | awk '{print $NF}') printf -- '-svn%s' "$rev" |