diff options
author | Yi Yang <yiyang13@huawei.com> | 2022-05-10 16:05:33 +0800 |
---|---|---|
committer | Max Filippov <jcmvbkbc@gmail.com> | 2022-05-11 02:15:38 -0700 |
commit | b011946d039d66bbc7102137e98cc67e1356aa87 (patch) | |
tree | 187e0f9ca53b97149bc795bf9945320ade1b1572 /scripts | |
parent | c6ab42b31fce42c4b7f775752d91db0f2b71c65e (diff) | |
download | linux-b011946d039d66bbc7102137e98cc67e1356aa87.tar.gz linux-b011946d039d66bbc7102137e98cc67e1356aa87.tar.bz2 linux-b011946d039d66bbc7102137e98cc67e1356aa87.zip |
xtensa/simdisk: fix proc_read_simdisk()
The commit a69755b18774 ("xtensa simdisk: switch to proc_create_data()")
split read operation into two parts, first retrieving the path when it's
non-null and second retrieving the trailing '\n'. However when the path
is non-null the first simple_read_from_buffer updates ppos, and the
second simple_read_from_buffer returns 0 if ppos is greater than 1 (i.e.
almost always). As a result reading from that proc file is almost always
empty.
Fix it by making a temporary copy of the path with the trailing '\n' and
using simple_read_from_buffer on that copy.
Cc: stable@vger.kernel.org
Fixes: a69755b18774 ("xtensa simdisk: switch to proc_create_data()")
Signed-off-by: Yi Yang <yiyang13@huawei.com>
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
Diffstat (limited to 'scripts')
0 files changed, 0 insertions, 0 deletions