summaryrefslogtreecommitdiffstats
path: root/security/keys
diff options
context:
space:
mode:
authorOleg Nesterov <oleg@redhat.com>2010-05-26 14:43:23 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2010-05-27 09:12:47 -0700
commitdd98acf74762764fbc4382a1d9a244f11a2658cc (patch)
treee194cc516ccc8812a0424dfd2ca1c32bf1052cd4 /security/keys
parent5089a9768041206c76fac299ccd82a528c24c254 (diff)
downloadlinux-dd98acf74762764fbc4382a1d9a244f11a2658cc.tar.gz
linux-dd98acf74762764fbc4382a1d9a244f11a2658cc.tar.bz2
linux-dd98acf74762764fbc4382a1d9a244f11a2658cc.zip
keyctl_session_to_parent(): use thread_group_empty() to check singlethreadness
No functional changes. keyctl_session_to_parent() is the only user of signal->count which needs the correct value. Change it to use thread_group_empty() instead, this must be strictly equivalent under tasklist, and imho looks better. Signed-off-by: Oleg Nesterov <oleg@redhat.com> Acked-by: David Howells <dhowells@redhat.com> Cc: Peter Zijlstra <peterz@infradead.org> Acked-by: Roland McGrath <roland@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'security/keys')
-rw-r--r--security/keys/keyctl.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/security/keys/keyctl.c b/security/keys/keyctl.c
index 8f4dce1987c4..13074b454743 100644
--- a/security/keys/keyctl.c
+++ b/security/keys/keyctl.c
@@ -1269,7 +1269,7 @@ long keyctl_session_to_parent(void)
goto not_permitted;
/* the parent must be single threaded */
- if (atomic_read(&parent->signal->count) != 1)
+ if (!thread_group_empty(parent))
goto not_permitted;
/* the parent and the child must have different session keyrings or