summaryrefslogtreecommitdiffstats
path: root/security
diff options
context:
space:
mode:
authorOndrej Mosnacek <omosnace@redhat.com>2019-03-25 09:11:15 +0100
committerPaul Moore <paul@paul-moore.com>2019-03-25 10:25:06 -0400
commit9e0cfe28fa32f6fefd831192a4d0b19c804c746b (patch)
tree128cf5a7abfcc3f1756159be339abb81b72d550d /security
parent24f7c45fdb2a17ef6ad3142e9a8ba4066ac674a2 (diff)
downloadlinux-9e0cfe28fa32f6fefd831192a4d0b19c804c746b.tar.gz
linux-9e0cfe28fa32f6fefd831192a4d0b19c804c746b.tar.bz2
linux-9e0cfe28fa32f6fefd831192a4d0b19c804c746b.zip
selinux: remove useless assignments
The code incorrectly assigned directly to the variables instead of the values they point to. Since the values are already set to NULL/0 at the beginning of the function, we can simply remove these useless assignments. Reported-by: Hariprasad Kelam <hariprasad.kelam@gmail.com> Fixes: fede148324c3 ("selinux: log invalid contexts in AVCs") Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com> [PM: removed a bad comment that was causing compiler warnings] Signed-off-by: Paul Moore <paul@paul-moore.com>
Diffstat (limited to 'security')
-rw-r--r--security/selinux/ss/services.c7
1 files changed, 2 insertions, 5 deletions
diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c
index ec62918521b1..cc043bc8fd4c 100644
--- a/security/selinux/ss/services.c
+++ b/security/selinux/ss/services.c
@@ -1318,14 +1318,11 @@ static int security_sid_to_context_core(struct selinux_state *state,
rc = -EINVAL;
goto out_unlock;
}
- if (only_invalid && !context->len) {
- scontext = NULL;
- scontext_len = 0;
+ if (only_invalid && !context->len)
rc = 0;
- } else {
+ else
rc = context_struct_to_string(policydb, context, scontext,
scontext_len);
- }
out_unlock:
read_unlock(&state->ss->policy_rwlock);
out: