summaryrefslogtreecommitdiffstats
path: root/sound/isa/sb/sb_common.c
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2014-11-21 19:32:02 +0100
committerTakashi Iwai <tiwai@suse.de>2014-11-21 20:07:36 +0100
commit966b7bc9354ab8f59f0ef2d96306615157e0f76e (patch)
treeeee31a0a126fe660d86821bdc1ec623308892cc5 /sound/isa/sb/sb_common.c
parent42d772101274492ca15258ea346e6ebbc2bc9bd0 (diff)
downloadlinux-966b7bc9354ab8f59f0ef2d96306615157e0f76e.tar.gz
linux-966b7bc9354ab8f59f0ef2d96306615157e0f76e.tar.bz2
linux-966b7bc9354ab8f59f0ef2d96306615157e0f76e.zip
ALSA: sb: Deletion of unnecessary checks before two function calls
The functions release_and_free_resource() and snd_util_memhdr_free() test whether their argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/isa/sb/sb_common.c')
-rw-r--r--sound/isa/sb/sb_common.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/sound/isa/sb/sb_common.c b/sound/isa/sb/sb_common.c
index 3ef990602cdd..f22b4480828e 100644
--- a/sound/isa/sb/sb_common.c
+++ b/sound/isa/sb/sb_common.c
@@ -184,8 +184,7 @@ static int snd_sbdsp_probe(struct snd_sb * chip)
static int snd_sbdsp_free(struct snd_sb *chip)
{
- if (chip->res_port)
- release_and_free_resource(chip->res_port);
+ release_and_free_resource(chip->res_port);
if (chip->irq >= 0)
free_irq(chip->irq, (void *) chip);
#ifdef CONFIG_ISA