diff options
| author | Takashi Iwai <tiwai@suse.de> | 2020-09-30 13:30:08 +0200 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2020-11-28 09:42:51 +0100 |
| commit | faba002e5fe91aae09ac591187be71c9e201b8f0 (patch) | |
| tree | 5783219554f6d7b66ee674438fcfcf26aa6924a6 /sound/pci/hda | |
| parent | 9be9f2d3d073ef42127475f4fb6a392ab133f629 (diff) | |
| download | linux-faba002e5fe91aae09ac591187be71c9e201b8f0.tar.gz linux-faba002e5fe91aae09ac591187be71c9e201b8f0.tar.bz2 linux-faba002e5fe91aae09ac591187be71c9e201b8f0.zip | |
ALSA: hda/ca0132: Move unsol callback setups to parser
The setup of unsolicited event callbacks should be done only once at
the parser phase, not in the init phase that is called multiple times
at each resume.
This patch moves the unsol setup code in ca0132 codec driver to the
more appropriate place.
Reported-by: Hui Wang <hui.wang@canonical.com>
Link: https://lore.kernel.org/r/20200930113008.9307-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci/hda')
| -rw-r--r-- | sound/pci/hda/patch_ca0132.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c index d8370a417e3d..4fbec4258f58 100644 --- a/sound/pci/hda/patch_ca0132.c +++ b/sound/pci/hda/patch_ca0132.c @@ -8544,7 +8544,7 @@ static void amic_callback(struct hda_codec *codec, struct hda_jack_callback *cb) ca0132_select_mic(codec); } -static void ca0132_init_unsol(struct hda_codec *codec) +static void ca0132_setup_unsol(struct hda_codec *codec) { struct ca0132_spec *spec = codec->spec; snd_hda_jack_detect_enable_callback(codec, spec->unsol_tag_hp, hp_callback); @@ -9376,7 +9376,6 @@ static int ca0132_init(struct hda_codec *codec) if (ca0132_quirk(spec) == QUIRK_AE5 || ca0132_quirk(spec) == QUIRK_AE7) ae5_register_set(codec); - ca0132_init_unsol(codec); ca0132_init_params(codec); ca0132_init_flags(codec); @@ -9941,6 +9940,8 @@ static int patch_ca0132(struct hda_codec *codec) if (err < 0) goto error; + ca0132_setup_unsol(codec); + return 0; error: |