summaryrefslogtreecommitdiffstats
path: root/sound/pci
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2015-07-25 03:03:38 +0300
committerTakashi Iwai <tiwai@suse.de>2015-07-25 08:19:04 +0200
commit44008f0896ae205b02b0882dbf807f0de149efc4 (patch)
tree12f2c76fdf1f820aa5be14dfae826d8867dbafbe /sound/pci
parent43cbf02e7ad51007af38f39c5b2abdc7a5d7f5aa (diff)
downloadlinux-44008f0896ae205b02b0882dbf807f0de149efc4.tar.gz
linux-44008f0896ae205b02b0882dbf807f0de149efc4.tar.bz2
linux-44008f0896ae205b02b0882dbf807f0de149efc4.zip
ALSA: hda - fix cs4210_spdif_automute()
Smatch complains that we have nested checks for "spdif_present". It turns out the current behavior isn't correct, we should remove the first check and keep the second. Fixes: 1077a024812d ('ALSA: hda - Use generic parser for Cirrus codec driver') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci')
-rw-r--r--sound/pci/hda/patch_cirrus.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/sound/pci/hda/patch_cirrus.c b/sound/pci/hda/patch_cirrus.c
index 25ccf781fbe7..584a0343ab0c 100644
--- a/sound/pci/hda/patch_cirrus.c
+++ b/sound/pci/hda/patch_cirrus.c
@@ -999,9 +999,7 @@ static void cs4210_spdif_automute(struct hda_codec *codec,
spec->spdif_present = spdif_present;
/* SPDIF TX on/off */
- if (spdif_present)
- snd_hda_set_pin_ctl(codec, spdif_pin,
- spdif_present ? PIN_OUT : 0);
+ snd_hda_set_pin_ctl(codec, spdif_pin, spdif_present ? PIN_OUT : 0);
cs_automute(codec);
}