diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2022-03-04 16:13:35 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2022-03-07 13:14:48 +0000 |
| commit | 00925272f166db31fed73f3c00c151eb5f7ce1d8 (patch) | |
| tree | 9ebd58bb598e5bd2b58b8bb9081caae014fc1c66 /sound/soc/amd | |
| parent | 899a9a7f624b5a9d100c9ac6b3f0960981f0e4c5 (diff) | |
| download | linux-00925272f166db31fed73f3c00c151eb5f7ce1d8.tar.gz linux-00925272f166db31fed73f3c00c151eb5f7ce1d8.tar.bz2 linux-00925272f166db31fed73f3c00c151eb5f7ce1d8.zip | |
ASoC: amd: pcm-dma: Fix signedness bug in acp_pdm_audio_probe()
The "adata->pdm_irq" variable is unsigned so the error handling will
not work.
Fixes: 87d71a128771 ("ASoC: amd: pcm-dma: Use platform_get_irq() to get the interrupt")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20220304131335.GB28739@kili
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/amd')
| -rw-r--r-- | sound/soc/amd/renoir/acp3x-pdm-dma.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/sound/soc/amd/renoir/acp3x-pdm-dma.c b/sound/soc/amd/renoir/acp3x-pdm-dma.c index 88a242538461..8c42345ee41e 100644 --- a/sound/soc/amd/renoir/acp3x-pdm-dma.c +++ b/sound/soc/amd/renoir/acp3x-pdm-dma.c @@ -399,9 +399,10 @@ static int acp_pdm_audio_probe(struct platform_device *pdev) if (!adata->acp_base) return -ENOMEM; - adata->pdm_irq = platform_get_irq(pdev, 0); - if (adata->pdm_irq < 0) - return -ENODEV; + status = platform_get_irq(pdev, 0); + if (status < 0) + return status; + adata->pdm_irq = status; adata->capture_stream = NULL; |