summaryrefslogtreecommitdiffstats
path: root/sound/soc/samsung/littlemill.c
diff options
context:
space:
mode:
authorWen Yang <wen.yang99@zte.com.cn>2019-07-13 11:46:15 +0800
committerMark Brown <broonie@kernel.org>2019-07-16 19:17:15 +0100
commit2abee12c0ab1924a69993d2c063a39a952e7d836 (patch)
tree11b8ba762db6f3ff703ae84f0416efe2f11ca7ba /sound/soc/samsung/littlemill.c
parent9b6d104a6b150bd4d3e5b039340e1f6b20c2e3c1 (diff)
downloadlinux-2abee12c0ab1924a69993d2c063a39a952e7d836.tar.gz
linux-2abee12c0ab1924a69993d2c063a39a952e7d836.tar.bz2
linux-2abee12c0ab1924a69993d2c063a39a952e7d836.zip
ASoC: samsung: odroid: fix a double-free issue for cpu_dai
The cpu_dai variable is still being used after the of_node_put() call, which may result in double-free: of_node_put(cpu_dai); ---> released here ret = devm_snd_soc_register_card(dev, card); if (ret < 0) { ... goto err_put_clk_i2s; --> jump to err_put_clk_i2s ... err_put_clk_i2s: clk_put(priv->clk_i2s_bus); err_put_sclk: clk_put(priv->sclk_i2s); err_put_cpu_dai: of_node_put(cpu_dai); --> double-free here Fixes: d832d2b246c5 ("ASoC: samsung: odroid: Fix of_node refcount unbalance") Signed-off-by: Wen Yang <wen.yang99@zte.com.cn> Cc: Krzysztof Kozlowski <krzk@kernel.org> Cc: Sangbeom Kim <sbkim73@samsung.com> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> Cc: Liam Girdwood <lgirdwood@gmail.com> Cc: Mark Brown <broonie@kernel.org> Cc: Jaroslav Kysela <perex@perex.cz> Cc: Takashi Iwai <tiwai@suse.com> Cc: alsa-devel@alsa-project.org Cc: linux-kernel@vger.kernel.org Link: https://lore.kernel.org/r/1562989575-33785-3-git-send-email-wen.yang99@zte.com.cn Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/samsung/littlemill.c')
0 files changed, 0 insertions, 0 deletions