diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-10-14 00:19:53 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2023-10-23 13:29:48 +0100 |
| commit | 7242265213893e053457240f833d06ecd75b7ab3 (patch) | |
| tree | 4341e9e004355d628c1e48b64da3cf3ebc1685f3 /sound/soc/uniphier/aio-ld11.c | |
| parent | d0cc676c426d1958989fac2a0d45179fb9992f0a (diff) | |
| download | linux-7242265213893e053457240f833d06ecd75b7ab3.tar.gz linux-7242265213893e053457240f833d06ecd75b7ab3.tar.bz2 linux-7242265213893e053457240f833d06ecd75b7ab3.zip | |
ASoC: uniphier: Make uniphier_aio_remove() return void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
uniphier_aio_remove() returned zero unconditionally. Make it return
void instead and convert all users to struct
platform_device::remove_new().
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20231013221945.1489203-16-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/uniphier/aio-ld11.c')
| -rw-r--r-- | sound/soc/uniphier/aio-ld11.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/uniphier/aio-ld11.c b/sound/soc/uniphier/aio-ld11.c index 15dbded63804..01cc3b961999 100644 --- a/sound/soc/uniphier/aio-ld11.c +++ b/sound/soc/uniphier/aio-ld11.c @@ -347,7 +347,7 @@ static struct platform_driver uniphier_aio_driver = { .of_match_table = of_match_ptr(uniphier_aio_of_match), }, .probe = uniphier_aio_probe, - .remove = uniphier_aio_remove, + .remove_new = uniphier_aio_remove, }; module_platform_driver(uniphier_aio_driver); |