diff options
| author | Oder Chiou <oder_chiou@realtek.com> | 2017-11-09 19:28:10 +0800 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2017-11-09 11:35:54 +0000 |
| commit | ba68fa318442d25586d057c1e8c9165bdc62c1b3 (patch) | |
| tree | b4c33f65967ddc2979bc1d78f4b9011634d43b25 /sound/soc | |
| parent | 457c25efc592bb5539e18161c505f7a865013fb7 (diff) | |
| download | linux-ba68fa318442d25586d057c1e8c9165bdc62c1b3.tar.gz linux-ba68fa318442d25586d057c1e8c9165bdc62c1b3.tar.bz2 linux-ba68fa318442d25586d057c1e8c9165bdc62c1b3.zip | |
ASoC: rt5663: Delay and retry reading rt5663 ID register
In the probe, the codec may not be ready for I2C reading or there are some
glitches on the i2c line. So if the i2c reading value is incorrect, it will
read again after delay. This issue is similar the patch
https://patchwork.kernel.org/patch/9681421/. In current project, these 2
devices were connected to the same i2c line, and they met the same problem.
Signed-off-by: Oder Chiou <oder_chiou@realtek.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc')
| -rw-r--r-- | sound/soc/codecs/rt5663.c | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/sound/soc/codecs/rt5663.c b/sound/soc/codecs/rt5663.c index 767f219f6c42..eb3065a992ab 100644 --- a/sound/soc/codecs/rt5663.c +++ b/sound/soc/codecs/rt5663.c @@ -3428,7 +3428,16 @@ static int rt5663_i2c_probe(struct i2c_client *i2c, ret); return ret; } - regmap_read(regmap, RT5663_VENDOR_ID_2, &val); + + ret = regmap_read(regmap, RT5663_VENDOR_ID_2, &val); + if (ret || (val != RT5663_DEVICE_ID_2 && val != RT5663_DEVICE_ID_1)) { + dev_err(&i2c->dev, + "Device with ID register %#x is not rt5663, retry one time.\n", + val); + msleep(100); + regmap_read(regmap, RT5663_VENDOR_ID_2, &val); + } + switch (val) { case RT5663_DEVICE_ID_2: rt5663->regmap = devm_regmap_init_i2c(i2c, &rt5663_v2_regmap); |