diff options
| author | Dinghao Liu <dinghao.liu@zju.edu.cn> | 2020-05-29 09:22:28 +0800 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2020-05-29 13:30:04 +0100 |
| commit | 65bd91dd6957390c42a0491b9622cf31a2cdb140 (patch) | |
| tree | 0bdca9b2c17c3a3c495a4ca04502e6004bbfc462 /sound | |
| parent | 4a0434502191347ba8f99468f2fb2cdddc20d381 (diff) | |
| download | linux-65bd91dd6957390c42a0491b9622cf31a2cdb140.tar.gz linux-65bd91dd6957390c42a0491b9622cf31a2cdb140.tar.bz2 linux-65bd91dd6957390c42a0491b9622cf31a2cdb140.zip | |
ASoC: img-i2s-out: Fix runtime PM imbalance on error
pm_runtime_get_sync() increments the runtime PM usage counter even
the call returns an error code. Thus a pairing decrement is needed
on the error handling path to keep the counter balanced.
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Link: https://lore.kernel.org/r/20200529012230.5863-1-dinghao.liu@zju.edu.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/soc/img/img-i2s-out.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/sound/soc/img/img-i2s-out.c b/sound/soc/img/img-i2s-out.c index db052ec17d5d..b56a18e7f3ac 100644 --- a/sound/soc/img/img-i2s-out.c +++ b/sound/soc/img/img-i2s-out.c @@ -347,8 +347,10 @@ static int img_i2s_out_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) chan_control_mask = IMG_I2S_OUT_CHAN_CTL_CLKT_MASK; ret = pm_runtime_get_sync(i2s->dev); - if (ret < 0) + if (ret < 0) { + pm_runtime_put_noidle(i2s->dev); return ret; + } img_i2s_out_disable(i2s); @@ -488,8 +490,10 @@ static int img_i2s_out_probe(struct platform_device *pdev) goto err_pm_disable; } ret = pm_runtime_get_sync(&pdev->dev); - if (ret < 0) + if (ret < 0) { + pm_runtime_put_noidle(&pdev->dev); goto err_suspend; + } reg = IMG_I2S_OUT_CTL_FRM_SIZE_MASK; img_i2s_out_writel(i2s, reg, IMG_I2S_OUT_CTL); |