summaryrefslogtreecommitdiffstats
path: root/sound
diff options
context:
space:
mode:
authorDaniel Mack <daniel@zonque.org>2014-10-07 13:41:23 +0200
committerMark Brown <broonie@kernel.org>2014-10-07 13:12:28 +0100
commitdecc27b01d584c985c231e73d3b493de6ec07af8 (patch)
treef8a453869deb5eea00e7f41ec4f1f8de5c492be2 /sound
parent6596aa047b624aeec2ea321962cfdecf9953a383 (diff)
downloadlinux-decc27b01d584c985c231e73d3b493de6ec07af8.tar.gz
linux-decc27b01d584c985c231e73d3b493de6ec07af8.tar.bz2
linux-decc27b01d584c985c231e73d3b493de6ec07af8.zip
ASoC: core: fix use after free in snd_soc_remove_platform()
Coverity spotted an use-after-free condition in snd_soc_remove_platform(). Fix this by moving snd_soc_component_cleanup() after the debug print statement which uses the component's string. Signed-off-by: Daniel Mack <daniel@zonque.org> Signed-off-by: Mark Brown <broonie@kernel.org> Cc: stable@vger.kernel.org
Diffstat (limited to 'sound')
-rw-r--r--sound/soc/soc-core.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index ae48f1013e80..d877ec57d761 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -4315,10 +4315,10 @@ void snd_soc_remove_platform(struct snd_soc_platform *platform)
snd_soc_component_del_unlocked(&platform->component);
mutex_unlock(&client_mutex);
- snd_soc_component_cleanup(&platform->component);
-
dev_dbg(platform->dev, "ASoC: Unregistered platform '%s'\n",
platform->component.name);
+
+ snd_soc_component_cleanup(&platform->component);
}
EXPORT_SYMBOL_GPL(snd_soc_remove_platform);