diff options
author | Masahiro Yamada <yamada.masahiro@socionext.com> | 2017-08-20 15:04:11 +0900 |
---|---|---|
committer | Masahiro Yamada <yamada.masahiro@socionext.com> | 2017-09-01 08:50:32 +0900 |
commit | 8e9b466799230bc20a029579e92d4cd526e5a2e1 (patch) | |
tree | 3b51d498c991f1e22bf482c0e59e0c2d203faac4 /tools/power | |
parent | aae4e7a8bc44722fe70d58920a36916b1043195e (diff) | |
download | linux-8e9b466799230bc20a029579e92d4cd526e5a2e1.tar.gz linux-8e9b466799230bc20a029579e92d4cd526e5a2e1.tar.bz2 linux-8e9b466799230bc20a029579e92d4cd526e5a2e1.zip |
kbuild: use $(abspath ...) instead of $(shell cd ... && /bin/pwd)
Kbuild conventionally uses $(shell cd ... && /bin/pwd) idiom to get
the absolute path of the directory because GNU Make 3.80, the minimal
supported version at that time, did not support $(abspath ...) or
$(realpath ...).
Commit 37d69ee30808 ("docs: bump minimal GNU Make version to 3.81")
dropped the GNU Make 3.80 support, so we are now allowed to use those
make-builtin helpers.
This conversion will provide better portability without relying on
the pwd command or its location /bin/pwd.
I am intentionally using $(realpath ...) instead $(abspath ...) in
some places. The difference between the two is $(realpath ...)
returns an empty string if the given path does not exist. It is
convenient in places where we need to error-out if the makefile fails
to create an output directory.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Diffstat (limited to 'tools/power')
-rw-r--r-- | tools/power/cpupower/Makefile | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/power/cpupower/Makefile b/tools/power/cpupower/Makefile index d6e1c02ddcfe..4c5a481a850c 100644 --- a/tools/power/cpupower/Makefile +++ b/tools/power/cpupower/Makefile @@ -26,7 +26,7 @@ endif ifneq ($(OUTPUT),) # check that the output directory actually exists -OUTDIR := $(shell cd $(OUTPUT) && /bin/pwd) +OUTDIR := $(realpath $(OUTPUT)) $(if $(OUTDIR),, $(error output directory "$(OUTPUT)" does not exist)) endif |