diff options
author | Michael Ellerman <mpe@ellerman.id.au> | 2015-03-11 15:05:59 +1100 |
---|---|---|
committer | Shuah Khan <shuahkh@osg.samsung.com> | 2015-03-13 15:13:40 -0600 |
commit | 5e29a9105b1a0da86eff0ad6ae015997b49d4d1d (patch) | |
tree | 8c913c799dc3d6251efec0e681ef738ec38a3f4e /tools/testing/selftests/firmware | |
parent | 7fe5f1c16c2c7904c7b8fcfb93e691893f21e8d3 (diff) | |
download | linux-5e29a9105b1a0da86eff0ad6ae015997b49d4d1d.tar.gz linux-5e29a9105b1a0da86eff0ad6ae015997b49d4d1d.tar.bz2 linux-5e29a9105b1a0da86eff0ad6ae015997b49d4d1d.zip |
selftests: Introduce minimal shared logic for running tests
This adds a Make include file which most selftests can then include to
get the run_tests logic.
On its own this has the advantage of some reduction in repetition, and
also means the pass/fail message is defined in fewer places.
However the key advantage is it will allow us to implement install very
simply in a subsequent patch.
The default implementation just executes each program in $(TEST_PROGS).
We use a variable to hold the default implementation of $(RUN_TESTS)
because that gives us a clean way to override it if necessary, ie. using
override. The mount, memory-hotplug and mqueue tests use that to provide
a different implementation.
Tests are not run via /bin/bash, so if they are scripts they must be
executable, we add a+x to several.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
Diffstat (limited to 'tools/testing/selftests/firmware')
-rw-r--r-- | tools/testing/selftests/firmware/Makefile | 20 | ||||
-rwxr-xr-x[-rw-r--r--] | tools/testing/selftests/firmware/fw_filesystem.sh | 0 | ||||
-rwxr-xr-x[-rw-r--r--] | tools/testing/selftests/firmware/fw_userhelper.sh | 0 |
3 files changed, 2 insertions, 18 deletions
diff --git a/tools/testing/selftests/firmware/Makefile b/tools/testing/selftests/firmware/Makefile index e23cce0bbc3a..9bf82234855b 100644 --- a/tools/testing/selftests/firmware/Makefile +++ b/tools/testing/selftests/firmware/Makefile @@ -3,25 +3,9 @@ # No binaries, but make sure arg-less "make" doesn't trigger "run_tests" all: -fw_filesystem: - @if /bin/sh ./fw_filesystem.sh ; then \ - echo "fw_filesystem: ok"; \ - else \ - echo "fw_filesystem: [FAIL]"; \ - exit 1; \ - fi +TEST_PROGS := fw_filesystem.sh fw_userhelper.sh -fw_userhelper: - @if /bin/sh ./fw_userhelper.sh ; then \ - echo "fw_userhelper: ok"; \ - else \ - echo "fw_userhelper: [FAIL]"; \ - exit 1; \ - fi - -run_tests: all fw_filesystem fw_userhelper +include ../lib.mk # Nothing to clean up. clean: - -.PHONY: all clean run_tests fw_filesystem fw_userhelper diff --git a/tools/testing/selftests/firmware/fw_filesystem.sh b/tools/testing/selftests/firmware/fw_filesystem.sh index 3fc6c10c2479..3fc6c10c2479 100644..100755 --- a/tools/testing/selftests/firmware/fw_filesystem.sh +++ b/tools/testing/selftests/firmware/fw_filesystem.sh diff --git a/tools/testing/selftests/firmware/fw_userhelper.sh b/tools/testing/selftests/firmware/fw_userhelper.sh index 6efbade12139..6efbade12139 100644..100755 --- a/tools/testing/selftests/firmware/fw_userhelper.sh +++ b/tools/testing/selftests/firmware/fw_userhelper.sh |