summaryrefslogtreecommitdiffstats
path: root/virt
diff options
context:
space:
mode:
authorDavid Woodhouse <dwmw@amazon.co.uk>2024-02-27 11:49:17 +0000
committerSean Christopherson <seanjc@google.com>2024-03-04 16:22:37 -0800
commit66e3cf729b1ea017cad643415ade319556862b68 (patch)
tree197f09d57570987c0ee36e2f2e6e372730d1f5e8 /virt
parent8e62bf2bfa46367e14d0ffdcde5aada08759497c (diff)
downloadlinux-66e3cf729b1ea017cad643415ade319556862b68.tar.gz
linux-66e3cf729b1ea017cad643415ade319556862b68.tar.bz2
linux-66e3cf729b1ea017cad643415ade319556862b68.zip
KVM: x86/xen: remove WARN_ON_ONCE() with false positives in evtchn delivery
The kvm_xen_inject_vcpu_vector() function has a comment saying "the fast version will always work for physical unicast", justifying its use of kvm_irq_delivery_to_apic_fast() and the WARN_ON_ONCE() when that fails. In fact that assumption isn't true if X2APIC isn't in use by the guest and there is (8-bit x)APIC ID aliasing. A single "unicast" destination APIC ID *may* then be delivered to multiple vCPUs. Remove the warning, and in fact it might as well just call kvm_irq_delivery_to_apic(). Reported-by: Michal Luczaj <mhal@rbox.co> Fixes: fde0451be8fb3 ("KVM: x86/xen: Support per-vCPU event channel upcall via local APIC") Signed-off-by: David Woodhouse <dwmw@amazon.co.uk> Reviewed-by: Paul Durrant <paul@xen.org> Link: https://lore.kernel.org/r/20240227115648.3104-4-dwmw2@infradead.org Signed-off-by: Sean Christopherson <seanjc@google.com>
Diffstat (limited to 'virt')
0 files changed, 0 insertions, 0 deletions