summaryrefslogtreecommitdiffstats
path: root/package/network
diff options
context:
space:
mode:
authorPaul Donald <newtwen@gmail.com>2024-02-08 21:44:56 +0100
committerRobert Marko <robimarko@gmail.com>2024-03-11 09:58:20 +0100
commitbd1b17d589bc622408cebdd9fa0f43386cc3ef5a (patch)
treed979c674a32c4d3946133b2b7c071e5f94c0ec79 /package/network
parent24a4da527f7e70d9916439a78298de2f4e4af653 (diff)
downloadopenwrt-bd1b17d589bc622408cebdd9fa0f43386cc3ef5a.tar.gz
openwrt-bd1b17d589bc622408cebdd9fa0f43386cc3ef5a.tar.bz2
openwrt-bd1b17d589bc622408cebdd9fa0f43386cc3ef5a.zip
lldpd: remove unneeded quotes and variable quoting
from commit ac771313ebedd2c4bfda8adef47650d45d77c32d portidsubtype takes 1 of 2 possible keywords which do not need quoting: configure lldp portidsubtype ifname | macaddress The third keyword 'local' is used in the syntax when individual ports are being defined: configure [ports ethX [,…]] lldp portidsubtype local value When this syntax is used, quoting is useful (see test cases for lldpd). In the init file, the 'local' syntax is unused. Tested on 22.03.5 Signed-off-by: Paul Donald <newtwen@gmail.com>
Diffstat (limited to 'package/network')
-rw-r--r--package/network/services/lldpd/files/lldpd.init2
1 files changed, 1 insertions, 1 deletions
diff --git a/package/network/services/lldpd/files/lldpd.init b/package/network/services/lldpd/files/lldpd.init
index 243a32c937..5d06e13aa5 100644
--- a/package/network/services/lldpd/files/lldpd.init
+++ b/package/network/services/lldpd/files/lldpd.init
@@ -154,7 +154,7 @@ write_lldpd_conf()
fi
fi
[ -n "$lldp_agenttype" ] && echo "configure lldp agent-type $lldp_agenttype" >> "$LLDPD_CONF"
- [ -n "$lldp_portidsubtype" ] && echo "configure lldp portidsubtype" "\"$lldp_portidsubtype\"" >> "$LLDPD_CONF"
+ [ -n "$lldp_portidsubtype" ] && echo "configure lldp portidsubtype $lldp_portidsubtype" >> "$LLDPD_CONF"
[ -n "$lldp_platform" ] && echo "configure system platform" "\"$lldp_platform\"" >> "$LLDPD_CONF"
[ $lldp_tx_interval -gt 0 ] && echo "configure lldp tx-interval" "$lldp_tx_interval" >> "$LLDPD_CONF"
[ $lldp_tx_hold -gt 0 ] && echo "configure lldp tx-hold" "$lldp_tx_hold" >> "$LLDPD_CONF"