diff options
| author | Christian Marangi <ansuelsmth@gmail.com> | 2023-11-12 16:15:07 +0100 |
|---|---|---|
| committer | Christian Marangi <ansuelsmth@gmail.com> | 2023-11-12 16:19:04 +0100 |
| commit | 9e49e0a6c4535d345084cc62c594be5cad23b911 (patch) | |
| tree | 7abfd73c8c167a5309220aa911b984727c8b491a /scripts | |
| parent | 10b130161d19ac839c6fae55bb376ac91d1ea211 (diff) | |
| download | openwrt-9e49e0a6c4535d345084cc62c594be5cad23b911.tar.gz openwrt-9e49e0a6c4535d345084cc62c594be5cad23b911.tar.bz2 openwrt-9e49e0a6c4535d345084cc62c594be5cad23b911.zip | |
scripts/getver.sh: prevent asking for negative rev-parse
With the case of asking an invalid version that is too big, getver.sh
might return an invalid output in the form of HEAD~-2260475641.
This is caused by BASE_REV - GET_REV using a negative number.
Prevent this by checking if BASE_REV - GET_REV actually return 0 or a
positive number and set REV variable accordingly. With the following
change, invalid revision number will result in unknown printed instead
of the invalid HEAD~-NUMBERS output.
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Diffstat (limited to 'scripts')
| -rwxr-xr-x | scripts/getver.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/getver.sh b/scripts/getver.sh index 49260a2260..61906040b1 100755 --- a/scripts/getver.sh +++ b/scripts/getver.sh @@ -21,7 +21,7 @@ try_git() { r*) GET_REV="$(echo $GET_REV | tr -d 'r')" BASE_REV="$(git rev-list ${REBOOT}..HEAD 2>/dev/null | wc -l | awk '{print $1}')" - REV="$(git rev-parse HEAD~$((BASE_REV - GET_REV)))" + [ $((BASE_REV - GET_REV)) -ge 0 ] && REV="$(git rev-parse HEAD~$((BASE_REV - GET_REV)))" ;; *) BRANCH="$(git rev-parse --abbrev-ref HEAD)" |