summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatt DeVillier <matt.devillier@gmail.com>2024-02-18 12:31:13 -0600
committerFelix Held <felix-coreboot@felixheld.de>2024-02-21 13:47:31 +0000
commit3f06e6c74089a1dffcf9340890c7b5bb10ea2119 (patch)
tree0ce07510750f81d3fd531c144568972d56ab4ffb
parentd6e287f41055e8893da6c6b663f60913a878ee92 (diff)
downloadcoreboot-3f06e6c74089a1dffcf9340890c7b5bb10ea2119.tar.gz
coreboot-3f06e6c74089a1dffcf9340890c7b5bb10ea2119.tar.bz2
coreboot-3f06e6c74089a1dffcf9340890c7b5bb10ea2119.zip
mb/google/volteer: Disable PM ACPI timer to fix S0i3 regression
Keeping the PM timer enabled will disqualify an ADL system from entering S0i3, and will also cause an increase in power during suspend states. The PM timer is not required for brya boards, therefore disabling it. Fixes: 0e90580 (soc/intel: transition full control over PM Timer from FSP to coreboot) This mirrors an identical commit for google/brya: 1ce0f3aab72d ("mb/google/brya: Fix S0i3 regression") TEST=Boot Linux on google/drobit, verify S0i3 counter incrementing after exiting S0ix suspend states. Change-Id: I644e42388c0f6127512bf52e774b79721601ecc9 Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80612 Reviewed-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-by: Paul Menzel <paulepanter@mailbox.org> Reviewed-by: Nico Huber <nico.h@gmx.de> Reviewed-by: Eric Lai <ericllai@google.com> Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/mainboard/google/volteer/Kconfig3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig
index f4914c723912..bc5ee6c10e42 100644
--- a/src/mainboard/google/volteer/Kconfig
+++ b/src/mainboard/google/volteer/Kconfig
@@ -243,4 +243,7 @@ config VARIANT_HAS_MIPI_CAMERA
bool
default n
+config USE_PM_ACPI_TIMER
+ default n
+
endif # BOARD_GOOGLE_BASEBOARD_VOLTEER