diff options
author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2021-11-02 10:36:20 +0200 |
---|---|---|
committer | Felix Held <felix-coreboot@felixheld.de> | 2022-04-06 17:40:50 +0000 |
commit | 4fdd84e716bb052bfbae58366c687be2656a97bb (patch) | |
tree | 1bdd3c1bed7b16f61ce971a0a552400257e58f88 /src/mainboard/intel/glkrvp | |
parent | afe5562ca39b26cc42ca04da55b68f73a7b70654 (diff) | |
download | coreboot-4fdd84e716bb052bfbae58366c687be2656a97bb.tar.gz coreboot-4fdd84e716bb052bfbae58366c687be2656a97bb.tar.bz2 coreboot-4fdd84e716bb052bfbae58366c687be2656a97bb.zip |
ChromeOS: Promote variant_cros_gpio()
The only purpose of mainboard_chromeos_acpi_generate()
was to pass cros_gpio array for ACPI \\OIPG package
generation.
Promote variant_cros_gpio() from baseboards to ChromeOS
declaration.
Change-Id: I5c2ac1dcea35f1f00dea401528404bc6ca0ab53c
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58897
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Diffstat (limited to 'src/mainboard/intel/glkrvp')
-rw-r--r-- | src/mainboard/intel/glkrvp/chromeos.c | 11 | ||||
-rw-r--r-- | src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/variants.h | 4 |
2 files changed, 0 insertions, 15 deletions
diff --git a/src/mainboard/intel/glkrvp/chromeos.c b/src/mainboard/intel/glkrvp/chromeos.c index 7a14c86bd269..bc27b27f3195 100644 --- a/src/mainboard/intel/glkrvp/chromeos.c +++ b/src/mainboard/intel/glkrvp/chromeos.c @@ -1,12 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <baseboard/variants.h> #include <bootmode.h> #include <boot/coreboot_tables.h> #include <ec/google/chromeec/ec.h> #include <gpio.h> #include <types.h> -#include <vendorcode/google/chromeos/chromeos.h> #include <soc/gpio.h> #include <variant/gpio.h> @@ -26,15 +24,6 @@ int get_write_protect_state(void) return 0; } -void mainboard_chromeos_acpi_generate(void) -{ - const struct cros_gpio *gpios; - size_t num; - - gpios = variant_cros_gpios(&num); - chromeos_acpi_gpio_generate(gpios, num); -} - int __weak get_lid_switch(void) { return -1; diff --git a/src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/variants.h b/src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/variants.h index f1df93783d8d..24c28f9ccd5c 100644 --- a/src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/variants.h @@ -5,7 +5,6 @@ #include <soc/gpio.h> #include <soc/meminit.h> -#include <vendorcode/google/chromeos/chromeos.h> /** * variant_board_id() - Get the board id for the current board variant @@ -27,9 +26,6 @@ const struct lpddr4_cfg *variant_lpddr4_config(void); /* Return memory SKU for the board. */ size_t variant_memory_sku(void); -/* Return ChromeOS gpio table and fill in number of entries. */ -const struct cros_gpio *variant_cros_gpios(size_t *num); - /* Seed the NHLT tables with the board specific information. */ struct nhlt; void variant_nhlt_init(struct nhlt *nhlt); |