summaryrefslogtreecommitdiffstats
path: root/util/intelp2m
diff options
context:
space:
mode:
authorMaxim Polyakov <max.senia.poliak@gmail.com>2021-06-30 16:14:53 +0300
committerPatrick Georgi <pgeorgi@google.com>2021-07-02 07:48:58 +0000
commit8b35851e4c994943fab1d0f0c484e5f38cd0729c (patch)
treef14fd90b4b8e2b5fcc6a6343cf9155e7eb27324a /util/intelp2m
parent421ce56f833edcfe34788ff07ebf5e09d582ff9f (diff)
downloadcoreboot-8b35851e4c994943fab1d0f0c484e5f38cd0729c.tar.gz
coreboot-8b35851e4c994943fab1d0f0c484e5f38cd0729c.tar.bz2
coreboot-8b35851e4c994943fab1d0f0c484e5f38cd0729c.zip
util/intelp2m: use import once for all included modules
There is no need to repeat "import" for each module in GoLang. Use this keyword only once in each file for code cleanliness. Change-Id: Ibb24fafd409b31b174946a39ca1f810d59b87e76 Signed-off-by: Maxim Polyakov <max.senia.poliak@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/55985 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Matt DeVillier <matt.devillier@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'util/intelp2m')
-rw-r--r--util/intelp2m/fields/cb/cb.go6
-rw-r--r--util/intelp2m/fields/fields.go13
-rw-r--r--util/intelp2m/fields/raw/raw.go6
-rw-r--r--util/intelp2m/main.go13
-rw-r--r--util/intelp2m/parser/parser.go13
-rw-r--r--util/intelp2m/platforms/apl/macro.go14
-rw-r--r--util/intelp2m/platforms/cnl/macro.go16
-rw-r--r--util/intelp2m/platforms/common/macro.go9
-rw-r--r--util/intelp2m/platforms/lbg/macro.go14
-rw-r--r--util/intelp2m/platforms/snr/macro.go14
10 files changed, 62 insertions, 56 deletions
diff --git a/util/intelp2m/fields/cb/cb.go b/util/intelp2m/fields/cb/cb.go
index 3bda62e71926..3603aac532bd 100644
--- a/util/intelp2m/fields/cb/cb.go
+++ b/util/intelp2m/fields/cb/cb.go
@@ -1,7 +1,9 @@
package cb
-import "../../config"
-import "../../platforms/common"
+import (
+ "../../config"
+ "../../platforms/common"
+)
type FieldMacros struct {}
diff --git a/util/intelp2m/fields/fields.go b/util/intelp2m/fields/fields.go
index d2ca0e8d80e4..e8d8625d0c97 100644
--- a/util/intelp2m/fields/fields.go
+++ b/util/intelp2m/fields/fields.go
@@ -1,11 +1,12 @@
package fields
-import "../config"
-import "../platforms/common"
-
-import "./fsp"
-import "./cb"
-import "./raw"
+import (
+ "../config"
+ "../platforms/common"
+ "./fsp"
+ "./cb"
+ "./raw"
+)
// InterfaceSet - set the interface for decoding configuration
// registers DW0 and DW1.
diff --git a/util/intelp2m/fields/raw/raw.go b/util/intelp2m/fields/raw/raw.go
index a54e51d9b1ab..e6fa25c7eefc 100644
--- a/util/intelp2m/fields/raw/raw.go
+++ b/util/intelp2m/fields/raw/raw.go
@@ -1,7 +1,9 @@
package raw
-import "fmt"
-import "../../platforms/common"
+import (
+ "fmt"
+ "../../platforms/common"
+)
type FieldMacros struct {}
diff --git a/util/intelp2m/main.go b/util/intelp2m/main.go
index 511f54d0d0b7..fdfc34f8c4aa 100644
--- a/util/intelp2m/main.go
+++ b/util/intelp2m/main.go
@@ -1,11 +1,12 @@
package main
-import "flag"
-import "fmt"
-import "os"
-
-import "./parser"
-import "./config"
+import (
+ "flag"
+ "fmt"
+ "os"
+ "./parser"
+ "./config"
+)
// generateOutputFile - generates include file
// parser : parser data structure
diff --git a/util/intelp2m/parser/parser.go b/util/intelp2m/parser/parser.go
index c0dc65f76991..bfcdff885970 100644
--- a/util/intelp2m/parser/parser.go
+++ b/util/intelp2m/parser/parser.go
@@ -5,15 +5,14 @@ import (
"fmt"
"strings"
"strconv"
+ "../platforms/common"
+ "../platforms/snr"
+ "../platforms/lbg"
+ "../platforms/apl"
+ "../platforms/cnl"
+ "../config"
)
-import "../platforms/common"
-import "../platforms/snr"
-import "../platforms/lbg"
-import "../platforms/apl"
-import "../platforms/cnl"
-import "../config"
-
// PlatformSpecific - platform-specific interface
type PlatformSpecific interface {
GenMacro(id string, dw0 uint32, dw1 uint32, ownership uint8) string
diff --git a/util/intelp2m/platforms/apl/macro.go b/util/intelp2m/platforms/apl/macro.go
index 0364067f110c..5f2707457050 100644
--- a/util/intelp2m/platforms/apl/macro.go
+++ b/util/intelp2m/platforms/apl/macro.go
@@ -1,12 +1,12 @@
package apl
-import "fmt"
-import "strconv"
-
-// Local packages
-import "../common"
-import "../../config"
-import "../../fields"
+import (
+ "fmt"
+ "strconv"
+ "../common"
+ "../../config"
+ "../../fields"
+)
const (
PAD_CFG_DW0_RO_FIELDS = (0x1 << 27) | (0x1 << 24) | (0x3 << 21) | (0xf << 16) | 0xfc
diff --git a/util/intelp2m/platforms/cnl/macro.go b/util/intelp2m/platforms/cnl/macro.go
index c3bdfc88b115..714bfa1b66b0 100644
--- a/util/intelp2m/platforms/cnl/macro.go
+++ b/util/intelp2m/platforms/cnl/macro.go
@@ -1,13 +1,13 @@
package cnl
-import "strings"
-import "fmt"
-
-// Local packages
-import "../common"
-import "../../config"
-import "../../fields"
-import "../snr"
+import (
+ "strings"
+ "fmt"
+ "../common"
+ "../../config"
+ "../../fields"
+ "../snr"
+)
const (
PAD_CFG_DW0_RO_FIELDS = (0x1 << 27) | (0x1 << 24) | (0x3 << 21) | (0xf << 16) | 0xfc
diff --git a/util/intelp2m/platforms/common/macro.go b/util/intelp2m/platforms/common/macro.go
index 38937f66b97e..ed42729d96a5 100644
--- a/util/intelp2m/platforms/common/macro.go
+++ b/util/intelp2m/platforms/common/macro.go
@@ -1,9 +1,10 @@
package common
-import "strconv"
-import "sync"
-
-import "../../config"
+import (
+ "strconv"
+ "sync"
+ "../../config"
+)
type Fields interface {
DecodeDW0()
diff --git a/util/intelp2m/platforms/lbg/macro.go b/util/intelp2m/platforms/lbg/macro.go
index 6b44a25885b6..003ea3f14b08 100644
--- a/util/intelp2m/platforms/lbg/macro.go
+++ b/util/intelp2m/platforms/lbg/macro.go
@@ -1,12 +1,12 @@
package lbg
-import "fmt"
-
-// Local packages
-import "../../config"
-import "../../fields"
-import "../common"
-import "../snr"
+import (
+ "fmt"
+ "../../config"
+ "../../fields"
+ "../common"
+ "../snr"
+)
const (
PAD_CFG_DW0_RO_FIELDS = (0x1 << 27) | (0x1 << 24) | (0x3 << 21) | (0xf << 16) | 0xfc
diff --git a/util/intelp2m/platforms/snr/macro.go b/util/intelp2m/platforms/snr/macro.go
index fb530c54c156..cebb0cd890f8 100644
--- a/util/intelp2m/platforms/snr/macro.go
+++ b/util/intelp2m/platforms/snr/macro.go
@@ -1,12 +1,12 @@
package snr
-import "strings"
-import "fmt"
-
-// Local packages
-import "../common"
-import "../../config"
-import "../../fields"
+import (
+ "strings"
+ "fmt"
+ "../common"
+ "../../config"
+ "../../fields"
+)
const (
PAD_CFG_DW0_RO_FIELDS = (0x1 << 27) | (0x1 << 24) | (0x3 << 21) | (0xf << 16) | 0xfc