summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorOliver Smith-Denny <osde@linux.microsoft.com>2023-06-02 13:23:52 -0700
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>2023-06-06 17:08:05 +0000
commitcdd20638bc97cef1356a5c687a412f869c637245 (patch)
treedd69c4aa39a2d07590c7a295f7bc05a7421e31cd
parent4bd0849d81b48233196092868081315ec4d9233d (diff)
downloadedk2-cdd20638bc97cef1356a5c687a412f869c637245.tar.gz
edk2-cdd20638bc97cef1356a5c687a412f869c637245.tar.bz2
edk2-cdd20638bc97cef1356a5c687a412f869c637245.zip
CharEncodingCheckPlugin: Remove Noisy Print
Currently, CharEncodingCheckPlugin prints a message for every file that passes the test, which for some platforms can cause most of the CI build log to be filled with this print. It does not add any value, so this patch removes the noisy print and only prints if the encoding check fails. Cc: Sean Brogan <sean.brogan@microsoft.com> Cc: Michael Kubacki <mikuback@linux.microsoft.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com> Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com> Signed-off-by: Oliver Smith-Denny <osde@linux.microsoft.com>
-rw-r--r--.pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py4
1 files changed, 1 insertions, 3 deletions
diff --git a/.pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py b/.pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py
index b09fb17040..07d9e9ce22 100644
--- a/.pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py
+++ b/.pytool/Plugin/CharEncodingCheck/CharEncodingCheck.py
@@ -93,9 +93,7 @@ class CharEncodingCheck(ICiBuildPlugin):
files = [Edk2pathObj.GetAbsolutePathOnThisSystemFromEdk2RelativePath(x) for x in files]
for a in files:
files_tested += 1
- if(self.TestEncodingOk(a, enc)):
- logging.debug("File {0} Passed Encoding Check {1}".format(a, enc))
- else:
+ if not self.TestEncodingOk(a, enc):
tc.LogStdError("Encoding Failure in {0}. Not {1}".format(a, enc))
overall_status += 1