diff options
| author | Star Zeng <star.zeng@intel.com> | 2019-07-17 11:19:48 +0800 |
|---|---|---|
| committer | Eric Dong <eric.dong@intel.com> | 2019-07-18 08:22:19 +0800 |
| commit | 04dd0cb972cd35f4bf59f5692096a65b840156d5 (patch) | |
| tree | d0f259c301eebbe5d688df916630dab5f2a93043 | |
| parent | cce01f538fb4d6ae8c13c88cfc0d3caf5baca833 (diff) | |
| download | edk2-04dd0cb972cd35f4bf59f5692096a65b840156d5.tar.gz edk2-04dd0cb972cd35f4bf59f5692096a65b840156d5.tar.bz2 edk2-04dd0cb972cd35f4bf59f5692096a65b840156d5.zip | |
UefiCpuPkg DxeRegisterCpuFeaturesLib: Fix VS2012 build failure
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1968
The new VS2012 build failure is caused by 7a0df26.
xxx\registercpufeatureslib\dxeregistercpufeatureslib.c(258) :
warning C4701: potentially uninitialized local variable 'MpEvent' used
It is a false positive alarm.
MpEvent is assigned at line 238 and will be used at line 258, both
lines are controlled by "if (CpuFeaturesData->NumberOfCpus > 1)".
This patch initializes MpEvent to suppress incorrect compiler/analyzer
warnings.
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Ray Ni <ray.ni@intel.com>
| -rw-r--r-- | UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c index ffd99046a6..f87b2892aa 100644 --- a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c +++ b/UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.c @@ -229,6 +229,12 @@ CpuFeaturesInitialize ( OldBspNumber = GetProcessorIndex (CpuFeaturesData);
CpuFeaturesData->BspNumber = OldBspNumber;
+ //
+ //
+ // Initialize MpEvent to suppress incorrect compiler/analyzer warnings.
+ //
+ MpEvent = NULL;
+
if (CpuFeaturesData->NumberOfCpus > 1) {
Status = gBS->CreateEvent (
EVT_NOTIFY_WAIT,
|