diff options
| author | Abdul Lateef Attar <AbdulLateef.Attar@amd.com> | 2024-09-19 09:26:10 +0000 |
|---|---|---|
| committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | 2024-09-20 09:02:41 +0000 |
| commit | 222e2854fe6bed443686e3809f155fd7b824fabd (patch) | |
| tree | b94c1ead100e91b7e9e7a154069a774b2ded38d8 | |
| parent | c3580093520809cbfe2abd0e702d53707b7782a9 (diff) | |
| download | edk2-222e2854fe6bed443686e3809f155fd7b824fabd.tar.gz edk2-222e2854fe6bed443686e3809f155fd7b824fabd.tar.bz2 edk2-222e2854fe6bed443686e3809f155fd7b824fabd.zip | |
BaseTools: Update RETURN_ERROR Macro in BaseTypes.h
This patch is to sync RETURN_ERROR macro with the
MdePkg/Include/Base.h
Ref: 1a89d9887f MdePkg:Update Return Error Macro in Base.h
Fixing RETURN_ERROR macro.
It is causing problem in Coverity Static analysis tool
as we are directly converting the UINT value to INTN.
Changing value from UINT to INTN might cause problema
Here we know that the values would not be in loss of data.
To increase the code quality and increase the static tool
analysis score we have to change it
Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
| -rw-r--r-- | BaseTools/Source/C/Include/Common/BaseTypes.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/BaseTools/Source/C/Include/Common/BaseTypes.h b/BaseTools/Source/C/Include/Common/BaseTypes.h index e669da894c..5093a2f1f9 100644 --- a/BaseTools/Source/C/Include/Common/BaseTypes.h +++ b/BaseTools/Source/C/Include/Common/BaseTypes.h @@ -4,6 +4,8 @@ This file is stand alone self consistent set of definitions.
Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
+ Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.
+
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -202,7 +204,7 @@ typedef UINTN RETURN_STATUS; #define ENCODE_ERROR(a) ((RETURN_STATUS)(MAX_BIT | (a)))
#define ENCODE_WARNING(a) ((RETURN_STATUS)(a))
-#define RETURN_ERROR(a) (((INTN)(RETURN_STATUS)(a)) < 0)
+#define RETURN_ERROR(a) (((RETURN_STATUS)(a)) >= MAX_BIT)
#define RETURN_SUCCESS 0
#define RETURN_LOAD_ERROR ENCODE_ERROR (1)
|