diff options
| author | Michael D Kinney <michael.d.kinney@intel.com> | 2024-02-18 12:59:49 -0800 |
|---|---|---|
| committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | 2024-02-27 19:28:19 +0000 |
| commit | 45ad13bb6445e18e339311962dc7eaedb8df1d6c (patch) | |
| tree | 2c135ed6e214fc0009b7d3b0b17dca40051321f8 | |
| parent | dae8c29dab546fad2801e70967855a9f6ae14ae0 (diff) | |
| download | edk2-45ad13bb6445e18e339311962dc7eaedb8df1d6c.tar.gz edk2-45ad13bb6445e18e339311962dc7eaedb8df1d6c.tar.bz2 edk2-45ad13bb6445e18e339311962dc7eaedb8df1d6c.zip | |
BaseTools/Scripts/PatchCheck: Return CommitMessageCheck errors
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4693
Commit signatures are checked and error messages are logged but
errors are not captured and returned from find_signatures() in the
CommitMessageCheck class. This causes signature errors to be
silently ignored by CI.
Update logic in CommitMessageCheck class to return errors
detected in commit message signatures.
Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>
Reviewed-by: Rebecca Cran <rebecca@bsdio.com>
| -rwxr-xr-x | BaseTools/Scripts/PatchCheck.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py index e600e0be44..158a2b30a5 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -202,7 +202,7 @@ class CommitMessageCheck: if s[2] != ' ':
self.error("There should be a space after '" + sig + ":'")
- EmailAddressCheck(s[3], sig)
+ self.ok &= EmailAddressCheck(s[3], sig).ok
return sigs
|