diff options
author | Laszlo Ersek <lersek@redhat.com> | 2014-11-06 14:21:03 +0000 |
---|---|---|
committer | lersek <lersek@Edk2> | 2014-11-06 14:21:03 +0000 |
commit | 547222da31347418296baff7aa879c244bf9c106 (patch) | |
tree | e20cc1f156b471f134148d522ab52fab7bb8b253 | |
parent | 5126ef789dd31312fa6722f9c9b77a9d7700371d (diff) | |
download | edk2-547222da31347418296baff7aa879c244bf9c106.tar.gz edk2-547222da31347418296baff7aa879c244bf9c106.tar.bz2 edk2-547222da31347418296baff7aa879c244bf9c106.zip |
OvmfPkg: BDS: optimize second argument in PlatformBdsEnterFrontPage() call
The second parameter of said function is "ConnectAllHappened", and if set
to TRUE, the function sets "gConnectAllHappened" to TRUE.
This global variable in turn controls whether Intel BDS code *itself*
calls BdsLibConnectAllDriversToAllControllers() in various places -- if
the indicator is TRUE, then the "connect all" is assumed to have been
performed, and Intel BDS doesn't do it itself.
OVMF should pass TRUE as "ConnectAllHappened", because a few lines before
our call to PlatformBdsEnterFrontPage(), we already connect everything
with BdsLibConnectAll(), which includes the effects of
BdsLibConnectAllDriversToAllControllers():
PlatformBdsPolicyBehavior() [OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c]
BdsLibConnectAll() [IntelFrameworkModulePkg/Library/GenericBdsLib/BdsConnect.c]
BdsLibConnectAllDriversToAllControllers()
PlatformBdsEnterFrontPage() [IntelFrameworkModulePkg/Universal/BdsDxe/FrontPage.c]
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16308 6f19259b-4bc3-4df7-8a09-765794883524
-rw-r--r-- | OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c b/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c index f2ece66817..9fa48c98d0 100644 --- a/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c +++ b/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c @@ -1193,7 +1193,7 @@ Returns: //
// Enter Setup if user input
//
- PlatformBdsEnterFrontPage (Timeout, FALSE);
+ PlatformBdsEnterFrontPage (Timeout, TRUE);
}
}
|