summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorZhiguang Liu <zhiguang.liu@intel.com>2024-03-08 13:46:23 +0800
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>2024-04-16 04:41:27 +0000
commitda7858117f12846e5c35922e8917fd0da07dcfef (patch)
tree2a2c0627af65434b8fb052e3affa4344a6bc97b4
parentb594fba4ec5e2a9730979060a24d29d9daaa7bbc (diff)
downloadedk2-da7858117f12846e5c35922e8917fd0da07dcfef.tar.gz
edk2-da7858117f12846e5c35922e8917fd0da07dcfef.tar.bz2
edk2-da7858117f12846e5c35922e8917fd0da07dcfef.zip
Revert ae1079b386a597108a8070652bf7cdaa4ec3dda3
This reverts "MdeModulePkg/SMM: Support to unregister SMI handler inside SMI handler" for better design later. Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Jiaxin Wu <jiaxin.wu@intel.com> Cc: Ray Ni <ray.ni@intel.com> Cc: Laszlo Ersek <lersek@redhat.com> Reviewed-by: Ray Ni <ray.ni@intel.com> Cc: Laszlo Ersek <lersek@redhat.com> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> Cc: Sami Mujawar <sami.mujawar@arm.com> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
-rw-r--r--MdeModulePkg/Core/PiSmmCore/Smi.c8
1 files changed, 1 insertions, 7 deletions
diff --git a/MdeModulePkg/Core/PiSmmCore/Smi.c b/MdeModulePkg/Core/PiSmmCore/Smi.c
index 3489c130fd..2985f989c3 100644
--- a/MdeModulePkg/Core/PiSmmCore/Smi.c
+++ b/MdeModulePkg/Core/PiSmmCore/Smi.c
@@ -134,14 +134,8 @@ SmiManage (
Head = &SmiEntry->SmiHandlers;
- for (Link = Head->ForwardLink; Link != Head;) {
+ for (Link = Head->ForwardLink; Link != Head; Link = Link->ForwardLink) {
SmiHandler = CR (Link, SMI_HANDLER, Link, SMI_HANDLER_SIGNATURE);
- //
- // To support unregister SMI handler inside SMI handler itself,
- // get next node before handler is executed, since LIST_ENTRY that
- // Link points to may be freed if unregister SMI handler.
- //
- Link = Link->ForwardLink;
Status = SmiHandler->Handler (
(EFI_HANDLE)SmiHandler,