summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Kubacki <michael.kubacki@microsoft.com>2020-08-06 12:05:39 -0700
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>2020-08-07 02:30:01 +0000
commite4e27351e858b2a520db06398d86f2511fbcefbe (patch)
tree6ad67d64db74b476206bb95d2cb3c5bd26c4f15f
parent86652264641337d960275514056ec94613ecda24 (diff)
downloadedk2-e4e27351e858b2a520db06398d86f2511fbcefbe.tar.gz
edk2-e4e27351e858b2a520db06398d86f2511fbcefbe.tar.bz2
edk2-e4e27351e858b2a520db06398d86f2511fbcefbe.zip
FmpDevicePkg/FmpDependencyCheckLib: Return unsatisfied on handle failure
CheckFmpDependency () will currently return that dependencies are satisfied if the initial call in the function to locate handles that have gEfiFirmwareManagementProtocolGuid installed fails. This change updates the error handling to return FALSE (dependencies are not satisfied) if this handle search fails. Cc: Liming Gao <liming.gao@intel.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Guomin Jiang <guomin.jiang@intel.com> Cc: Wei6 Xu <wei6.xu@intel.com> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com> Reviewed-by: Guomin Jiang <guomin.jiang@intel.com> Reviewed-by: Wei6 Xu <wei6.xu@intel.com>
-rw-r--r--FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependencyCheckLib.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependencyCheckLib.c b/FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependencyCheckLib.c
index 5e0241b259..02ed600e0e 100644
--- a/FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependencyCheckLib.c
+++ b/FmpDevicePkg/Library/FmpDependencyCheckLib/FmpDependencyCheckLib.c
@@ -2,6 +2,7 @@
Provides FMP capsule dependency check services when updating the firmware
image of a FMP device.
+ Copyright (c) Microsoft Corporation.<BR>
Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -75,6 +76,7 @@ CheckFmpDependency (
);
if (EFI_ERROR (Status)) {
DEBUG ((DEBUG_ERROR, "CheckFmpDependency: Get Firmware Management Protocol failed. (%r)", Status));
+ IsSatisfied = FALSE;
goto cleanup;
}