diff options
| author | Pierre Gondois <Pierre.Gondois@arm.com> | 2020-12-10 10:40:51 +0000 |
|---|---|---|
| committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | 2021-01-06 16:22:54 +0000 |
| commit | 31ea1d2e071f94216a4db7e2de234b3e2dcc24c2 (patch) | |
| tree | f9b61edc18486fe9ef29f14d513cf48bb48cb978 /ArmPkg | |
| parent | f66c2b32cc1b0992def1923dd9ad9c3e4678e102 (diff) | |
| download | edk2-31ea1d2e071f94216a4db7e2de234b3e2dcc24c2.tar.gz edk2-31ea1d2e071f94216a4db7e2de234b3e2dcc24c2.tar.bz2 edk2-31ea1d2e071f94216a4db7e2de234b3e2dcc24c2.zip | |
ArmPkg: Fix Ecc error 3002 in ArmDisassemblerLib
This patch fixes the following Ecc reported error:
Non-Boolean comparisons should use a compare operator
(==, !=, >, < >=, <=)
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
Diffstat (limited to 'ArmPkg')
| -rw-r--r-- | ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c b/ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c index d206cf4ea9..abaacca53a 100644 --- a/ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c +++ b/ArmPkg/Library/ArmDisassemblerLib/ArmDisassembler.c @@ -2,6 +2,7 @@ Default exception handler
Copyright (c) 2008 - 2010, Apple Inc. All rights reserved.<BR>
+ Copyright (c) 2021, Arm Limited. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -367,7 +368,11 @@ DisassembleArmInstruction ( AsciiSPrint (Buf, Size, "CPS #0x%x", (OpCode & 0x2f));
} else {
imode = (OpCode >> 18) & 0x3;
- Index = AsciiSPrint (Buf, Size, "CPS%a %a%a%a", (imode == 3) ? "ID":"IE", (OpCode & BIT8) ? "A":"", (OpCode & BIT7) ? "I":"", (OpCode & BIT6) ? "F":"");
+ Index = AsciiSPrint (Buf, Size, "CPS%a %a%a%a",
+ (imode == 3) ? "ID":"IE",
+ ((OpCode & BIT8) != 0) ? "A":"",
+ ((OpCode & BIT7) != 0) ? "I":"",
+ ((OpCode & BIT6) != 0) ? "F":"");
if ((OpCode & BIT17) != 0) {
AsciiSPrint (&Buf[Index], Size - Index, ", #0x%x", OpCode & 0x1f);
}
|