summaryrefslogtreecommitdiffstats
path: root/ArmPkg
diff options
context:
space:
mode:
authorArd Biesheuvel <ard.biesheuvel@linaro.org>2015-05-07 15:37:10 +0000
committeroliviermartin <oliviermartin@Edk2>2015-05-07 15:37:10 +0000
commitffaa6b46ef42a5044aedbbcf16bf3cfdfd822de0 (patch)
tree4238ac74b31da757b7be78ee33ea2e8989dae56b /ArmPkg
parent80f882abd92f43a0f108ce83db58738618a19706 (diff)
downloadedk2-ffaa6b46ef42a5044aedbbcf16bf3cfdfd822de0.tar.gz
edk2-ffaa6b46ef42a5044aedbbcf16bf3cfdfd822de0.tar.bz2
edk2-ffaa6b46ef42a5044aedbbcf16bf3cfdfd822de0.zip
ArmPkg: fix pointer indirection bug in BdsFirmwareVolumeLoadImage()
The EFI_FIRMWARE_VOLUME2_PROTOCOL::EFI_FV_READ_SECTION prototype takes a pointer to a pointer to an output buffer, so we should not dereference Image (which is a pointer to pointer type itself) but pass its value directly. Contributed-under: TianoCore Contribution Agreement 1.0 Reviewed-by: Olivier Martin <olivier.martin@arm.com> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@17357 6f19259b-4bc3-4df7-8a09-765794883524
Diffstat (limited to 'ArmPkg')
-rw-r--r--ArmPkg/Library/BdsLib/BdsFilePath.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/ArmPkg/Library/BdsLib/BdsFilePath.c b/ArmPkg/Library/BdsLib/BdsFilePath.c
index a0a949d014..83a483cf88 100644
--- a/ArmPkg/Library/BdsLib/BdsFilePath.c
+++ b/ArmPkg/Library/BdsLib/BdsFilePath.c
@@ -697,7 +697,7 @@ BdsFirmwareVolumeLoadImage (
Status = FwVol->ReadFile (
FwVol,
FvNameGuid,
- (VOID*)(UINTN)(*Image),
+ (VOID**)Image,
ImageSize,
&FvType,
&Attrib,