ArmPlatformPkg/ArmPlatformLib: Move the UEFI memory partionning to MemoryInitPei

    
Formerly, each platform was responsible to declare the location of its UEFI memory
region (used by PEI and DXE Foundations).
The ArmPlatformLib was also declaring every region of its partitionned system memory
with a System Resource HOB.
    
In this new model, the MemoryInit expects the system memory to be declared with the
PCDs gArmTokenSpaceGuid.PcdSystemMemoryBase/Size.
These PCDs declare the largest continuous DRAM region. Additional regions can be
declared with the ArmPLatformLib function ArmPlatformGetAdditionalSystemMemory().
    
Now, it is the PEIM that partitions the system memory for every platform. It installs
a region of the size PcdSystemMemoryUefiRegionSize (default 128MB) for the PEI permanent
memory at the top of the DRAM region.
And a region of gArmPlatformTokenSpaceGuid.PcdSystemMemoryFixRegionSize (default 128MB)
is declared at the base of the system memory. This region is used for the allocation that
requires fixed address or have some constraints on their locations.



git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@11481 6f19259b-4bc3-4df7-8a09-765794883524

9 files changed, 152 insertions, 192 deletions

diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b/ArmPlatformPkg/ArmPlatformPkg.dec
index b9e7a7a8fc..9240efa2f6 100644
--- a/ArmPlatformPkg/ArmPlatformPkg.dec
+++ b/ArmPlatformPkg/ArmPlatformPkg.dec
@@ -55,3 +55,9 @@
   # Stack for CPU Cores in Non Secure Mode
   gArmPlatformTokenSpaceGuid.PcdCPUCoresNonSecStackBase|0|UINT32|0x00000008
   gArmPlatformTokenSpaceGuid.PcdCPUCoresNonSecStackSize|0|UINT32|0x00000009
+    
+  # Size of the region used by UEFI in permanent memory (Reserved 128MB by default)
+  gArmPlatformTokenSpaceGuid.PcdSystemMemoryUefiRegionSize|0x08000000|UINT32|0x00000015
+
+  # Size of the region reserved for fixed address allocations (Reserved 128MB by default)
+  gArmPlatformTokenSpaceGuid.PcdSystemMemoryFixRegionSize|0x08000000|UINT32|0x00000014
diff --git a/ArmPlatformPkg/ArmRealViewEbPkg/ArmRealViewEb-RTSM-A8.dsc b/ArmPlatformPkg/ArmRealViewEbPkg/ArmRealViewEb-RTSM-A8.dsc
index 2f2c5c8c8f..ca52ae6dc1 100644
--- a/ArmPlatformPkg/ArmRealViewEbPkg/ArmRealViewEb-RTSM-A8.dsc
+++ b/ArmPlatformPkg/ArmRealViewEbPkg/ArmRealViewEb-RTSM-A8.dsc
@@ -326,6 +326,13 @@
   gArmTokenSpaceGuid.PcdNormalFdBaseAddress|0x40050000       # Must be equal to gEmbeddedTokenSpaceGuid.PcdFlashFvMainBase

   gArmTokenSpaceGuid.PcdNormalFdSize|0x00100000              # Must be equal to gEmbeddedTokenSpaceGuid.PcdFlashFvMainSize

   

+  # System Memory (256MB) 

+  gArmTokenSpaceGuid.PcdSystemMemoryBase|0x70000000

+  gArmTokenSpaceGuid.PcdSystemMemorySize|0x10000000

+  

+  # Size of the region used by UEFI in permanent memory (Reserved 64MB)

+  gArmPlatformTokenSpaceGuid.PcdSystemMemoryUefiRegionSize|0x04000000

+  

   gEmbeddedTokenSpaceGuid.PcdTimerPeriod|100000        # expressed in 100ns units, 100,000 x 100 ns = 10,000,000 ns = 10 ms

   

   #

diff --git a/ArmPlatformPkg/ArmRealViewEbPkg/ArmRealViewEb-RTSM-A9x2.dsc b/ArmPlatformPkg/ArmRealViewEbPkg/ArmRealViewEb-RTSM-A9x2.dsc
index 912fad00ca..1eb833f63a 100644
--- a/ArmPlatformPkg/ArmRealViewEbPkg/ArmRealViewEb-RTSM-A9x2.dsc
+++ b/ArmPlatformPkg/ArmRealViewEbPkg/ArmRealViewEb-RTSM-A9x2.dsc
@@ -330,6 +330,13 @@
   gArmTokenSpaceGuid.PcdNormalFdBaseAddress|0x40050000       # Must be equal to gEmbeddedTokenSpaceGuid.PcdFlashFvMainBase
   gArmTokenSpaceGuid.PcdNormalFdSize|0x00100000              # Must be equal to gEmbeddedTokenSpaceGuid.PcdFlashFvMainSize
   
+  # System Memory (256MB) 
+  gArmTokenSpaceGuid.PcdSystemMemoryBase|0x70000000
+  gArmTokenSpaceGuid.PcdSystemMemorySize|0x10000000
+  
+  # Size of the region used by UEFI in permanent memory (Reserved 64MB)
+  gArmPlatformTokenSpaceGuid.PcdSystemMemoryUefiRegionSize|0x04000000
+  
   gEmbeddedTokenSpaceGuid.PcdTimerPeriod|100000        # expressed in 100ns units, 100,000 x 100 ns = 10,000,000 ns = 10 ms
   
   #
diff --git a/ArmPlatformPkg/ArmRealViewEbPkg/Library/ArmRealViewEbLibRTSM/ArmRealViewEbMem.c b/ArmPlatformPkg/ArmRealViewEbPkg/Library/ArmRealViewEbLibRTSM/ArmRealViewEbMem.c
index 01720bb23e..95fd2bb484 100644
--- a/ArmPlatformPkg/ArmRealViewEbPkg/Library/ArmRealViewEbLibRTSM/ArmRealViewEbMem.c
+++ b/ArmPlatformPkg/ArmRealViewEbPkg/Library/ArmRealViewEbLibRTSM/ArmRealViewEbMem.c
@@ -25,26 +25,6 @@
 #define DDR_ATTRIBUTES_SECURE_UNCACHED  ARM_MEMORY_REGION_ATTRIBUTE_SECURE_UNCACHED_UNBUFFERED

 

 /**

-  Return the information about the memory region in permanent memory used by PEI

-

-  One of the PEI Module must install the permament memory used by PEI. This function returns the

-  information about this region for your platform to this PEIM module.

-

-  @param[out]   PeiMemoryBase       Base of the memory region used by PEI core and modules

-  @param[out]   PeiMemorySize       Size of the memory region used by PEI core and modules

-

-**/

-VOID ArmPlatformGetPeiMemory (

-    OUT UINTN*                                   PeiMemoryBase,

-    OUT UINTN*                                   PeiMemorySize

-    ) {

-    ASSERT((PeiMemoryBase != NULL) && (PeiMemorySize != NULL));

-    

-    *PeiMemoryBase = ARM_EB_DRAM_BASE + ARM_EB_EFI_FIX_ADDRESS_REGION_SZ;

-    *PeiMemorySize = ARM_EB_EFI_MEMORY_REGION_SZ;

-}

-

-/**

   Return the Virtual Memory Map of your platform

 

   This Virtual Memory Map is used by MemoryInitPei Module to initialize the MMU on your platform.

@@ -136,67 +116,9 @@ VOID ArmPlatformGetVirtualMemoryMap(ARM_MEMORY_REGION_DESCRIPTOR** VirtualMemory
                                     EFI Memory region. This array must be ended by a zero-filled entry

 

 **/

-VOID ArmPlatformGetEfiMemoryMap (

+EFI_STATUS

+ArmPlatformGetAdditionalSystemMemory (

     OUT ARM_SYSTEM_MEMORY_REGION_DESCRIPTOR** EfiMemoryMap

 ) {

-    EFI_RESOURCE_ATTRIBUTE_TYPE     Attributes;

-    UINT64                          MemoryBase;

-    UINTN                           Index = 0;

-    ARM_SYSTEM_MEMORY_REGION_DESCRIPTOR  *EfiMemoryTable;

-

-    ASSERT(EfiMemoryMap != NULL);

-

-    EfiMemoryTable = (ARM_SYSTEM_MEMORY_REGION_DESCRIPTOR*)AllocatePages(sizeof(ARM_SYSTEM_MEMORY_REGION_DESCRIPTOR) * 6);

-

-    Attributes =

-    (

-      EFI_RESOURCE_ATTRIBUTE_PRESENT |

-      EFI_RESOURCE_ATTRIBUTE_INITIALIZED |

-      EFI_RESOURCE_ATTRIBUTE_UNCACHEABLE |

-      EFI_RESOURCE_ATTRIBUTE_WRITE_COMBINEABLE |

-      EFI_RESOURCE_ATTRIBUTE_WRITE_THROUGH_CACHEABLE |

-      EFI_RESOURCE_ATTRIBUTE_WRITE_BACK_CACHEABLE |

-      EFI_RESOURCE_ATTRIBUTE_TESTED

-    );

-    MemoryBase = ARM_EB_DRAM_BASE;

-  

-    // Memory Reserved for fixed address allocations (such as Exception Vector Table)

-    EfiMemoryTable[Index].ResourceAttribute = Attributes;

-    EfiMemoryTable[Index].PhysicalStart = MemoryBase;

-    EfiMemoryTable[Index].NumberOfBytes = ARM_EB_EFI_FIX_ADDRESS_REGION_SZ;

-    

-    MemoryBase += ARM_EB_EFI_FIX_ADDRESS_REGION_SZ;

-

-    // Memory declared to PEI as permanent memory for PEI and DXE

-    EfiMemoryTable[++Index].ResourceAttribute = Attributes;

-    EfiMemoryTable[Index].PhysicalStart = MemoryBase;

-    EfiMemoryTable[Index].NumberOfBytes = ARM_EB_EFI_MEMORY_REGION_SZ;

-

-    MemoryBase += ARM_EB_EFI_MEMORY_REGION_SZ;

-

-    // We must reserve the memory used by the Firmware Volume copied in DRAM at 0x80000000

-    if (FeaturePcdGet(PcdStandalone) == FALSE) {

-        // Chunk between the EFI Memory region and the firmware

-        EfiMemoryTable[++Index].ResourceAttribute = Attributes;

-        EfiMemoryTable[Index].PhysicalStart = MemoryBase;

-        EfiMemoryTable[Index].NumberOfBytes = PcdGet32(PcdNormalFdBaseAddress) - MemoryBase;

-

-        // Chunk reserved by the firmware in DRAM

-        EfiMemoryTable[++Index].ResourceAttribute = Attributes & (~EFI_RESOURCE_ATTRIBUTE_PRESENT);

-        EfiMemoryTable[Index].PhysicalStart = PcdGet32(PcdNormalFdBaseAddress);

-        EfiMemoryTable[Index].NumberOfBytes = PcdGet32(PcdNormalFdSize);

-

-        MemoryBase = PcdGet32(PcdNormalFdBaseAddress) + PcdGet32(PcdNormalFdSize);

-    }

-      

-    // We allocate all the remain memory as untested system memory

-    EfiMemoryTable[++Index].ResourceAttribute = Attributes & (~EFI_RESOURCE_ATTRIBUTE_TESTED);

-    EfiMemoryTable[Index].PhysicalStart = MemoryBase;

-    EfiMemoryTable[Index].NumberOfBytes = ARM_EB_DRAM_SZ - (MemoryBase-ARM_EB_DRAM_BASE);

-

-    EfiMemoryTable[++Index].ResourceAttribute = 0;

-    EfiMemoryTable[Index].PhysicalStart = 0;

-    EfiMemoryTable[Index].NumberOfBytes = 0;

-

-    *EfiMemoryMap = EfiMemoryTable;

+  return EFI_UNSUPPORTED;

 }

diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.dsc b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.dsc
index c0e3103a73..3dd56f1cc5 100644
--- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.dsc
+++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-CTA9x4.dsc
@@ -366,6 +366,11 @@
   gArmPlatformTokenSpaceGuid.PcdCPUCoresNonSecStackSize|0x00020000	# Stack for each of the 4 CPU cores
   gArmPlatformTokenSpaceGuid.PcdPeiServicePtrAddr|0x48020004        # pei services ptr just above stack. Overlapped with the stack of CoreId 1
 
+
+  # System Memory (1GB) 
+  gArmTokenSpaceGuid.PcdSystemMemoryBase|0x60000000
+  gArmTokenSpaceGuid.PcdSystemMemorySize|0x40000000
+    
   gEmbeddedTokenSpaceGuid.PcdTimerPeriod|100000        # expressed in 100ns units, 100,000 x 100 ns = 10,000,000 ns = 10 ms
   
   #
diff --git a/ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Mem.c b/ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Mem.c
index 8d1bf1f837..cd72f4af3c 100644
--- a/ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Mem.c
+++ b/ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibCTA9x4/CTA9x4Mem.c
@@ -25,26 +25,6 @@
 #define DDR_ATTRIBUTES_SECURE_UNCACHED  ARM_MEMORY_REGION_ATTRIBUTE_SECURE_UNCACHED_UNBUFFERED

 

 /**

-  Return the information about the memory region in permanent memory used by PEI

-

-  One of the PEI Module must install the permament memory used by PEI. This function returns the

-  information about this region for your platform to this PEIM module.

-

-  @param[out]   PeiMemoryBase       Base of the memory region used by PEI core and modules

-  @param[out]   PeiMemorySize       Size of the memory region used by PEI core and modules

-

-**/

-VOID ArmPlatformGetPeiMemory (

-    OUT UINTN*                                   PeiMemoryBase,

-    OUT UINTN*                                   PeiMemorySize

-    ) {

-    ASSERT((PeiMemoryBase != NULL) && (PeiMemorySize != NULL));

-    

-    *PeiMemoryBase = ARM_VE_DRAM_BASE + ARM_VE_EFI_FIX_ADDRESS_REGION_SZ;

-    *PeiMemorySize = ARM_VE_EFI_MEMORY_REGION_SZ;

-}

-

-/**

   Return the Virtual Memory Map of your platform

 

   This Virtual Memory Map is used by MemoryInitPei Module to initialize the MMU on your platform.

@@ -146,67 +126,10 @@ VOID ArmPlatformGetVirtualMemoryMap(ARM_MEMORY_REGION_DESCRIPTOR** VirtualMemory
                                     EFI Memory region. This array must be ended by a zero-filled entry

 

 **/

-VOID ArmPlatformGetEfiMemoryMap (

-    OUT ARM_SYSTEM_MEMORY_REGION_DESCRIPTOR** EfiMemoryMap

-) {

-    EFI_RESOURCE_ATTRIBUTE_TYPE     Attributes;

-    UINT64                          MemoryBase;

-    UINTN                           Index = 0;

-    ARM_SYSTEM_MEMORY_REGION_DESCRIPTOR  *EfiMemoryTable;

-

-    ASSERT(EfiMemoryMap != NULL);

-

-    EfiMemoryTable = (ARM_SYSTEM_MEMORY_REGION_DESCRIPTOR*)AllocatePages(sizeof(ARM_SYSTEM_MEMORY_REGION_DESCRIPTOR) * 6);

-

-    Attributes =

-    (

-      EFI_RESOURCE_ATTRIBUTE_PRESENT |

-      EFI_RESOURCE_ATTRIBUTE_INITIALIZED |

-      EFI_RESOURCE_ATTRIBUTE_UNCACHEABLE |

-      EFI_RESOURCE_ATTRIBUTE_WRITE_COMBINEABLE |

-      EFI_RESOURCE_ATTRIBUTE_WRITE_THROUGH_CACHEABLE |

-      EFI_RESOURCE_ATTRIBUTE_WRITE_BACK_CACHEABLE |

-      EFI_RESOURCE_ATTRIBUTE_TESTED

-    );

-    MemoryBase = ARM_VE_DRAM_BASE;

-  

-    // Memory Reserved for fixed address allocations (such as Exception Vector Table)

-    EfiMemoryTable[Index].ResourceAttribute = Attributes;

-    EfiMemoryTable[Index].PhysicalStart = MemoryBase;

-    EfiMemoryTable[Index].NumberOfBytes = ARM_VE_EFI_FIX_ADDRESS_REGION_SZ;

-    

-    MemoryBase += ARM_VE_EFI_FIX_ADDRESS_REGION_SZ;

-

-    // Memory declared to PEI as permanent memory for PEI and DXE

-    EfiMemoryTable[++Index].ResourceAttribute = Attributes;

-    EfiMemoryTable[Index].PhysicalStart = MemoryBase;

-    EfiMemoryTable[Index].NumberOfBytes = ARM_VE_EFI_MEMORY_REGION_SZ;

-

-    MemoryBase += ARM_VE_EFI_MEMORY_REGION_SZ;

-

-    // We must reserve the memory used by the Firmware Volume copied in DRAM at 0x80000000

-    if (FeaturePcdGet(PcdStandalone) == FALSE) {

-        // Chunk between the EFI Memory region and the firmware

-        EfiMemoryTable[++Index].ResourceAttribute = Attributes;

-        EfiMemoryTable[Index].PhysicalStart = MemoryBase;

-        EfiMemoryTable[Index].NumberOfBytes = PcdGet32(PcdNormalFdBaseAddress) - MemoryBase;

-

-        // Chunk reserved by the firmware in DRAM

-        EfiMemoryTable[++Index].ResourceAttribute = Attributes & (~EFI_RESOURCE_ATTRIBUTE_PRESENT);

-        EfiMemoryTable[Index].PhysicalStart = PcdGet32(PcdNormalFdBaseAddress);

-        EfiMemoryTable[Index].NumberOfBytes = PcdGet32(PcdNormalFdSize);

-

-        MemoryBase = PcdGet32(PcdNormalFdBaseAddress) + PcdGet32(PcdNormalFdSize);

-    }

-      

-    // We allocate all the remain memory as untested system memory

-    EfiMemoryTable[++Index].ResourceAttribute = Attributes & (~EFI_RESOURCE_ATTRIBUTE_TESTED);

-    EfiMemoryTable[Index].PhysicalStart = MemoryBase;

-    EfiMemoryTable[Index].NumberOfBytes = ARM_VE_DRAM_SZ - (MemoryBase-ARM_VE_DRAM_BASE);

-

-    EfiMemoryTable[++Index].ResourceAttribute = 0;

-    EfiMemoryTable[Index].PhysicalStart = 0;

-    EfiMemoryTable[Index].NumberOfBytes = 0;

-

-    *EfiMemoryMap = EfiMemoryTable;

+EFI_STATUS

+ArmPlatformGetAdditionalSystemMemory (

+  OUT ARM_SYSTEM_MEMORY_REGION_DESCRIPTOR** EfiMemoryMap

+  )

+{

+  return EFI_UNSUPPORTED;

 }

diff --git a/ArmPlatformPkg/Include/Library/ArmPlatformLib.h b/ArmPlatformPkg/Include/Library/ArmPlatformLib.h
index 83c19baabd..ec95941b51 100644
--- a/ArmPlatformPkg/Include/Library/ArmPlatformLib.h
+++ b/ArmPlatformPkg/Include/Library/ArmPlatformLib.h
@@ -170,8 +170,9 @@ VOID ArmPlatformGetVirtualMemoryMap (
                                     EFI Memory region. This array must be ended by a zero-filled entry
 
 **/
-VOID ArmPlatformGetEfiMemoryMap (
-    OUT ARM_SYSTEM_MEMORY_REGION_DESCRIPTOR** EfiMemoryMap
-);
+EFI_STATUS
+ArmPlatformGetAdditionalSystemMemory (
+  OUT ARM_SYSTEM_MEMORY_REGION_DESCRIPTOR** EfiMemoryMap
+  );
 
 #endif
diff --git a/ArmPlatformPkg/MemoryInitPei/MemoryInit.c b/ArmPlatformPkg/MemoryInitPei/MemoryInit.c
index 6f066c41f9..e616c075e1 100644
--- a/ArmPlatformPkg/MemoryInitPei/MemoryInit.c
+++ b/ArmPlatformPkg/MemoryInitPei/MemoryInit.c
@@ -32,6 +32,7 @@
 #include <Library/PeiServicesLib.h>

 #include <Library/ArmLib.h>

 #include <Library/IoLib.h>

+#include <Library/MemoryAllocationLib.h>

 #include <Library/ArmPlatformLib.h>

 

 //

@@ -90,12 +91,6 @@ BuildMemoryTypeInformationHob (
   BuildGuidDataHob (&gEfiMemoryTypeInformationGuid, &Info, sizeof (Info));

 }

 

-EFI_STATUS

-EFIAPI

-InitializeMemory (

-  IN       EFI_PEI_FILE_HANDLE  FileHandle,

-  IN CONST EFI_PEI_SERVICES     **PeiServices

-  )

 /*++

 

 Routine Description:

@@ -112,43 +107,129 @@ Returns:
   Status -  EFI_SUCCESS if the boot mode could be set

 

 --*/

+EFI_STATUS

+EFIAPI

+InitializeMemory (

+  IN       EFI_PEI_FILE_HANDLE  FileHandle,

+  IN CONST EFI_PEI_SERVICES     **PeiServices

+  )

 {

-  EFI_STATUS                    Status;

-  ARM_SYSTEM_MEMORY_REGION_DESCRIPTOR* EfiMemoryMap;

-  UINTN                         PeiMemoryBase;

-  UINTN                         PeiMemorySize;

-  UINTN                         Index;

+  EFI_STATUS                            Status;

+  EFI_RESOURCE_ATTRIBUTE_TYPE           Attributes;

+  ARM_SYSTEM_MEMORY_REGION_DESCRIPTOR*  EfiMemoryMap;

+  UINTN                                 Index;

+  UINTN                                 SystemMemoryTop;

+  UINTN                                 UefiMemoryBase;

+  UINTN                                 UefiMemorySize;

 

   DEBUG ((EFI_D_ERROR, "Memory Init PEIM Loaded\n"));

 

-  // If it is not a standalone version, then we need to initialize the System Memory

-  // In case of a standalone version, the DRAM is already initialized

+  // Ensure PcdSystemMemorySize has been set

+  ASSERT (FixedPcdGet32 (PcdSystemMemorySize) != 0);

+

+  SystemMemoryTop = FixedPcdGet32 (PcdSystemMemoryBase) + FixedPcdGet32 (PcdSystemMemorySize);

+

+  //

+  // Initialize the System Memory (DRAM)

+  //

   if (FeaturePcdGet(PcdStandalone)) {

-    // Initialize the System Memory controller (DRAM)

+    // In case of a standalone version, the DRAM is already initialized

     ArmPlatformInitializeSystemMemory();

   }

 

-  // Install the Memory to PEI

-  ArmPlatformGetPeiMemory (&PeiMemoryBase,&PeiMemorySize);

-  Status = PeiServicesInstallPeiMemory (PeiMemoryBase,PeiMemorySize);

+  //

+  // Declare the UEFI memory to PEI

+  //

+  if (FeaturePcdGet(PcdStandalone)) {

+    // In case of standalone UEFI, we set the UEFI memory region at the top of the DRAM

+    UefiMemoryBase = SystemMemoryTop - FixedPcdGet32 (PcdSystemMemoryUefiRegionSize);

+  } else {

+    // In case of a non standalone UEFI, we set the UEFI memory below the Firmware Volume

+    UefiMemoryBase = FixedPcdGet32 (PcdNormalFdBaseAddress) - FixedPcdGet32 (PcdSystemMemoryUefiRegionSize);

+  }

+  UefiMemorySize = FixedPcdGet32 (PcdSystemMemoryUefiRegionSize);

+  Status = PeiServicesInstallPeiMemory (UefiMemoryBase,UefiMemorySize);

   ASSERT_EFI_ERROR (Status);

 

   //

   // Now, the permanent memory has been installed, we can call AllocatePages()

   //

+  Attributes = (

+      EFI_RESOURCE_ATTRIBUTE_PRESENT |

+      EFI_RESOURCE_ATTRIBUTE_INITIALIZED |

+      EFI_RESOURCE_ATTRIBUTE_UNCACHEABLE |

+      EFI_RESOURCE_ATTRIBUTE_WRITE_COMBINEABLE |

+      EFI_RESOURCE_ATTRIBUTE_WRITE_THROUGH_CACHEABLE |

+      EFI_RESOURCE_ATTRIBUTE_WRITE_BACK_CACHEABLE |

+      EFI_RESOURCE_ATTRIBUTE_TESTED

+  );

+

+  // If it is not a standalone build we must reserved the space above the base address of the firmware volume

+  if (!FeaturePcdGet(PcdStandalone)) {

+    // Check if firmware volume has not be copied at the top of DRAM then we must reserve the extra space

+    // between the firmware and the top

+    if (SystemMemoryTop != FixedPcdGet32 (PcdNormalFdBaseAddress) + FixedPcdGet32 (PcdNormalFdSize)) {

+      BuildResourceDescriptorHob (

+          EFI_RESOURCE_SYSTEM_MEMORY,

+          Attributes & (~EFI_RESOURCE_ATTRIBUTE_TESTED),

+          FixedPcdGet32 (PcdNormalFdBaseAddress) + FixedPcdGet32 (PcdNormalFdSize),

+          SystemMemoryTop - (FixedPcdGet32 (PcdNormalFdBaseAddress) + FixedPcdGet32 (PcdNormalFdSize))

+      );

+    }

+

+    // Reserved the memory space occupied by the firmware volume

+    BuildResourceDescriptorHob (

+        EFI_RESOURCE_SYSTEM_MEMORY,

+        Attributes & (~EFI_RESOURCE_ATTRIBUTE_PRESENT),

+        (UINT32)FixedPcdGet32 (PcdNormalFdBaseAddress),

+        (UINT32)FixedPcdGet32 (PcdNormalFdSize)

+    );

+  }

 

-  ArmPlatformGetEfiMemoryMap (&EfiMemoryMap);

-

-  // Install the EFI Memory Map

-  for (Index = 0; EfiMemoryMap[Index].ResourceAttribute != 0; Index++) {

+  // Check there is no overlap between UEFI and Fix Address Regions

+  ASSERT (FixedPcdGet32 (PcdSystemMemoryBase) + FixedPcdGet32 (PcdSystemMemoryFixRegionSize) <= UefiMemoryBase);

+

+  // Reserved the UEFI Memory Region

+  BuildResourceDescriptorHob (

+      EFI_RESOURCE_SYSTEM_MEMORY,

+      Attributes,

+      UefiMemoryBase,

+      UefiMemorySize

+  );

+

+  // Reserved the Fix Address Region

+  BuildResourceDescriptorHob (

+      EFI_RESOURCE_SYSTEM_MEMORY,

+      Attributes,

+      FixedPcdGet32 (PcdSystemMemoryBase),

+      FixedPcdGet32 (PcdSystemMemoryFixRegionSize)

+  );

+

+  // Reserved the memory between UEFI and Fix Address regions

+  if (FixedPcdGet32 (PcdSystemMemoryBase) + FixedPcdGet32 (PcdSystemMemoryFixRegionSize) != UefiMemoryBase) {

     BuildResourceDescriptorHob (

         EFI_RESOURCE_SYSTEM_MEMORY,

-        EfiMemoryMap[Index].ResourceAttribute,

-        EfiMemoryMap[Index].PhysicalStart,

-        EfiMemoryMap[Index].NumberOfBytes

+        Attributes & (~EFI_RESOURCE_ATTRIBUTE_TESTED),

+        FixedPcdGet32 (PcdSystemMemoryBase) + FixedPcdGet32 (PcdSystemMemoryFixRegionSize),

+        UefiMemoryBase - (FixedPcdGet32 (PcdSystemMemoryBase) + FixedPcdGet32 (PcdSystemMemoryFixRegionSize))

     );

   }

 

+  // If a platform has system memory extensions, it can declare those in this function

+  Status = ArmPlatformGetAdditionalSystemMemory (&EfiMemoryMap);

+  if (!EFI_ERROR(Status)) {

+    // Install the EFI Memory Map

+    for (Index = 0; EfiMemoryMap[Index].ResourceAttribute != 0; Index++) {

+      BuildResourceDescriptorHob (

+          EFI_RESOURCE_SYSTEM_MEMORY,

+          EfiMemoryMap[Index].ResourceAttribute,

+          EfiMemoryMap[Index].PhysicalStart,

+          EfiMemoryMap[Index].NumberOfBytes

+      );

+    }

+    FreePool (EfiMemoryMap);

+  }

+

   // Build Memory Allocation Hob

   InitMmu ();

 

@@ -157,5 +238,5 @@ Returns:
     BuildMemoryTypeInformationHob ();

   }

 

-  return Status;

+  return EFI_SUCCESS;

 }

diff --git a/ArmPlatformPkg/MemoryInitPei/MemoryInitPei.inf b/ArmPlatformPkg/MemoryInitPei/MemoryInitPei.inf
index 3e4777626b..87ea168db3 100644
--- a/ArmPlatformPkg/MemoryInitPei/MemoryInitPei.inf
+++ b/ArmPlatformPkg/MemoryInitPei/MemoryInitPei.inf
@@ -54,6 +54,14 @@
   gArmPlatformTokenSpaceGuid.PcdStandalone

 

 [FixedPcd]

+  gArmTokenSpaceGuid.PcdNormalFdBaseAddress

+  gArmTokenSpaceGuid.PcdNormalFdSize

+

+  gArmTokenSpaceGuid.PcdSystemMemoryBase

+  gArmTokenSpaceGuid.PcdSystemMemorySize

+  gArmPlatformTokenSpaceGuid.PcdSystemMemoryFixRegionSize

+  gArmPlatformTokenSpaceGuid.PcdSystemMemoryUefiRegionSize

+  

   gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory

   gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIMemoryNVS

   gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType