ArmVirtPkg/PrePi: don't export PE/COFF and LZMA libraries via HOBs

The PrePi code we inherited from ArmPlatformPkg contains a rather
obscure optimization, where entry points of the PE/COFF and LZMA
handling routines are recorded in special HOBs, allowing DXE core
to call into that code directly rather than carry its own copy of
these libraries.

Given that no ArmVirtPkg platforms actually include the library
resolutions* that take advantage of these optimizations, let's not
bother with them, and remove the associated code.

* EmbeddedPkg/Library/LzmaHobCustomDecompressLib/LzmaHobCustomDecompressLib.inf
  EmbeddedPkg/Library/DxeHobPeCoffLib/DxeHobPeCoffLib.inf

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Acked-by: Laszlo Ersek <lersek@redhat.com>

1 files changed, 0 insertions, 11 deletions

diff --git a/ArmVirtPkg/PrePi/PrePi.c b/ArmVirtPkg/PrePi/PrePi.c
index fce4ab9428..f6abe2f201 100755
--- a/ArmVirtPkg/PrePi/PrePi.c
+++ b/ArmVirtPkg/PrePi/PrePi.c
@@ -17,7 +17,6 @@
 

 #include <Library/PrePiLib.h>

 #include <Library/PrintLib.h>

-#include <Library/PeCoffGetEntryPointLib.h>

 #include <Library/PrePiHobListPointerLib.h>

 #include <Library/TimerLib.h>

 #include <Library/PerformanceLib.h>

@@ -25,10 +24,8 @@
 

 #include <Ppi/GuidedSectionExtraction.h>

 #include <Ppi/ArmMpCoreInfo.h>

-#include <Guid/LzmaDecompress.h>

 

 #include "PrePi.h"

-#include "LzmaDecompress.h"

 

 VOID

 EFIAPI

@@ -98,14 +95,6 @@ PrePiMain (
   // SEC phase needs to run library constructors by hand.

   ProcessLibraryConstructorList ();

 

-  // Build HOBs to pass up our version of stuff the DXE Core needs to save space

-  BuildPeCoffLoaderHob ();

-  BuildExtractSectionHob (

-    &gLzmaCustomDecompressGuid,

-    LzmaGuidedSectionGetInfo,

-    LzmaGuidedSectionExtraction

-    );

-

   // Assume the FV that contains the SEC (our code) also contains a compressed FV.

   Status = DecompressFirstFv ();

   ASSERT_EFI_ERROR (Status);