BaseTools: Fix old python2 idioms

Based on "futurize -f lib2to3.fixes.fix_idioms"

* Change some type comparisons to isinstance() calls:
    type(x) == T -> isinstance(x, T)
    type(x) is T -> isinstance(x, T)
    type(x) != T -> not isinstance(x, T)
    type(x) is not T -> not isinstance(x, T)

* Change "while 1:" into "while True:".

* Change both

    v = list(EXPR)
    v.sort()
    foo(v)

and the more general

    v = EXPR
    v.sort()
    foo(v)

into

    v = sorted(EXPR)
    foo(v)

Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>

1 files changed, 3 insertions, 3 deletions

diff --git a/BaseTools/Scripts/UpdateBuildVersions.py b/BaseTools/Scripts/UpdateBuildVersions.py
index fb61b89bfb..269435bfa4 100755
--- a/BaseTools/Scripts/UpdateBuildVersions.py
+++ b/BaseTools/Scripts/UpdateBuildVersions.py
@@ -253,7 +253,7 @@ def GetSvnRevision(opts):
     StatusCmd = "svn st -v --depth infinity --non-interactive"

     contents = ShellCommandResults(StatusCmd, opts)

     os.chdir(Cwd)

-    if type(contents) is ListType:

+    if isinstance(contents, ListType):

         for line in contents:

             if line.startswith("M "):

                 Modified = True

@@ -263,7 +263,7 @@ def GetSvnRevision(opts):
     InfoCmd = "svn info %s" % SrcPath.replace("\\", "/").strip()

     Revision = 0

     contents = ShellCommandResults(InfoCmd, opts)

-    if type(contents) is IntType:

+    if isinstance(contents, IntType):

         return 0, Modified

     for line in contents:

         line = line.strip()

@@ -284,7 +284,7 @@ def CheckSvn(opts):
     VerCmd = "svn --version"

     contents = ShellCommandResults(VerCmd, opts)

     opts.silent = OriginalSilent

-    if type(contents) is IntType:

+    if isinstance(contents, IntType):

         if opts.verbose:

             sys.stdout.write("SVN does not appear to be available.\n")

             sys.stdout.flush()