BaseTools/EfiRom: Refine the logic in main()

This commit refines the logic for main(). It makes the logic more
straightforward to prevent possible mis-reports by static code
checkers.

Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>

1 files changed, 7 insertions, 5 deletions

diff --git a/BaseTools/Source/C/EfiRom/EfiRom.c b/BaseTools/Source/C/EfiRom/EfiRom.c
index 0f89280251..6648f4c738 100644
--- a/BaseTools/Source/C/EfiRom/EfiRom.c
+++ b/BaseTools/Source/C/EfiRom/EfiRom.c
@@ -101,11 +101,13 @@ Returns:
       // Find the last . on the line and replace the filename extension with

       // the default

       //

-      for (Ext = mOptions.OutFileName + strlen (mOptions.OutFileName) - 1;

-           (Ext >= mOptions.OutFileName) && (*Ext != '.') && (*Ext != '\\');

-           Ext--

-          )

-        ;

+      Ext = mOptions.OutFileName + strlen (mOptions.OutFileName) - 1;

+      while (Ext >= mOptions.OutFileName) {

+        if ((*Ext == '.') || (*Ext == '\\')) {

+          break;

+        }

+        Ext--;

+      }

       //

       // If dot here, then insert extension here, otherwise append

       //