BaseTools/GenFv: Fix file handles not being closed

Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>

1 files changed, 3 insertions, 0 deletions

diff --git a/BaseTools/Source/C/GenFv/GenFvInternalLib.c b/BaseTools/Source/C/GenFv/GenFvInternalLib.c
index bf6b40c4c4..8072c014fa 100644
--- a/BaseTools/Source/C/GenFv/GenFvInternalLib.c
+++ b/BaseTools/Source/C/GenFv/GenFvInternalLib.c
@@ -1161,6 +1161,7 @@ Returns:
   //

   FileBuffer = malloc (FileSize);

   if (FileBuffer == NULL) {

+    fclose (NewFile);

     Error (NULL, 0, 4001, "Resouce", "memory cannot be allocated!");

     return EFI_OUT_OF_RESOURCES;

   }

@@ -3506,6 +3507,7 @@ Returns:
           PeFileSize = _filelength (fileno (PeFile));

           PeFileBuffer = (UINT8 *) malloc (PeFileSize);

           if (PeFileBuffer == NULL) {

+            fclose (PeFile);

             Error (NULL, 0, 4001, "Resource", "memory cannot be allocated on rebase of %s", FileName);

             return EFI_OUT_OF_RESOURCES;

           }

@@ -3761,6 +3763,7 @@ Returns:
         PeFileSize = _filelength (fileno (PeFile));

         PeFileBuffer = (UINT8 *) malloc (PeFileSize);

         if (PeFileBuffer == NULL) {

+          fclose (PeFile);

           Error (NULL, 0, 4001, "Resource", "memory cannot be allocated on rebase of %s", FileName);

           return EFI_OUT_OF_RESOURCES;

         }