summaryrefslogtreecommitdiffstats
path: root/BaseTools/Source/Python/AutoGen/BuildEngine.py
diff options
context:
space:
mode:
authorGary Lin <glin@suse.com>2018-06-25 18:31:35 +0800
committerYonghong Zhu <yonghong.zhu@intel.com>2018-06-27 16:33:27 +0800
commit0d1f5b2b5dc3c1cf381be0a1ec8f960dc6029a93 (patch)
tree370c6121707d6141988e1795f061e93abc112cbb /BaseTools/Source/Python/AutoGen/BuildEngine.py
parent2617a73c3628473bacea887d885bdd1e7808ccc6 (diff)
downloadedk2-0d1f5b2b5dc3c1cf381be0a1ec8f960dc6029a93.tar.gz
edk2-0d1f5b2b5dc3c1cf381be0a1ec8f960dc6029a93.tar.bz2
edk2-0d1f5b2b5dc3c1cf381be0a1ec8f960dc6029a93.zip
BaseTools: Fix old python2 idioms
Based on "futurize -f lib2to3.fixes.fix_idioms" * Change some type comparisons to isinstance() calls: type(x) == T -> isinstance(x, T) type(x) is T -> isinstance(x, T) type(x) != T -> not isinstance(x, T) type(x) is not T -> not isinstance(x, T) * Change "while 1:" into "while True:". * Change both v = list(EXPR) v.sort() foo(v) and the more general v = EXPR v.sort() foo(v) into v = sorted(EXPR) foo(v) Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Yonghong Zhu <yonghong.zhu@intel.com> Cc: Liming Gao <liming.gao@intel.com> Signed-off-by: Gary Lin <glin@suse.com> Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
Diffstat (limited to 'BaseTools/Source/Python/AutoGen/BuildEngine.py')
-rw-r--r--BaseTools/Source/Python/AutoGen/BuildEngine.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/BaseTools/Source/Python/AutoGen/BuildEngine.py b/BaseTools/Source/Python/AutoGen/BuildEngine.py
index cab4c993dc..e205589c6b 100644
--- a/BaseTools/Source/Python/AutoGen/BuildEngine.py
+++ b/BaseTools/Source/Python/AutoGen/BuildEngine.py
@@ -68,7 +68,7 @@ class TargetDescBlock(object):
return hash(self.Target.Path)
def __eq__(self, Other):
- if type(Other) == type(self):
+ if isinstance(Other, type(self)):
return Other.Target.Path == self.Target.Path
else:
return str(Other) == self.Target.Path